refactor(fault-proof): avoid IO under write lock (#693)

* fix: switch to RwLock for state

* fix: lower fetch_interval for tests

* fix: try with fetch_interval=5

* fix: test_proposer_recovery_after_canonical_head_invalidation

* nit

* fix: missing e2e feature flag

* fix: up to 10

* fix: look up for correct parent_id

* nit: bring back e2e feature

* nit: docstring

* fix: single lock on removing subtree of invalid games

* refactor(fault-proof): avoid IO under write lock

---------

Co-authored-by: Farhad Shabani <[email protected]>

Author: fakedev9999

fault-proof/src/proposer.rs

@@ -987,10 +987,12 @@ where
     /// - The game type does not respect the expected type when created.
     /// - The output root claim is invalid.
     pub async fn fetch_game(&self, index: U256) -> Result<GameFetchResult> {
-        let mut state = self.state.write().await;
+        {
+            let state = self.state.read().await;
 
-        if state.games.contains_key(&index) {
-            return Ok(GameFetchResult::AlreadyExists);
+            if state.games.contains_key(&index) {
+                return Ok(GameFetchResult::AlreadyExists);
+            }
         }
 
         let game = self.factory.gameAtIndex(index).call().await?;
@@ -1059,6 +1061,7 @@ where
             "Valid game: adding to cache"
         );
 
+        let mut state = self.state.write().await;
         state.games.insert(
             index,
             Game {