Fix findbugs warnings

The serialize inner class cases are just suppressed for now.

Author: bpedersen2

src/main/java/org/jvnet/hudson/plugins/port_allocator/GlassFishJmxPortType.java

@@ -25,12 +25,14 @@
 import java.rmi.UnmarshalException;
 import java.util.HashMap;
 import java.util.Map;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; 
 
 /**
  * GlassFish JMX port so that runaway GF instance can be terminated.
  *
  * @author Kohsuke Kawaguchi
  */
+@SuppressFBWarnings(value="SE_INNER_CLASS")
 public class GlassFishJmxPortType extends PortType {
     /**
      * GlassFish admin user name.
@@ -48,6 +50,7 @@ public GlassFishJmxPortType(String name, String userName, String password) {
         this.password = password;
     }
 
+
     @Override
     public Port allocate(Run<?, ?> run, final PortAllocationManager manager, int prefPort, final Launcher launcher, final TaskListener taskListener)
         throws IOException, InterruptedException
@@ -61,7 +64,7 @@ public Port allocate(Run<?, ?> run, final PortAllocationManager manager, int pre
         /**
          * Cleans up GlassFish instance.
          */
-        final class GlassFishCleanUpTask implements Callable<Void,IOException>, Serializable {
+        class GlassFishCleanUpTask implements Callable<Void,IOException>, Serializable {
             private final TaskListener taskListener;
 
             public GlassFishCleanUpTask(TaskListener taskListener) {

src/main/java/org/jvnet/hudson/plugins/port_allocator/PoolNotDefinedException.java

@@ -3,5 +3,5 @@
 /**
  * @author pepov
  */
-public class PoolNotDefinedException extends Throwable {
+public class PoolNotDefinedException extends Exception {
 }

src/main/java/org/jvnet/hudson/plugins/port_allocator/PortAllocationManager.java

@@ -24,7 +24,7 @@
  */
 
 public final class PortAllocationManager implements Serializable {
-    private final Computer node;
+    private transient final Computer node;
 
     /** Maximum number of tries to allocate a specific port range. */
     private static final int MAX_TRIES = 100;
@@ -261,4 +261,6 @@ public Integer call() throws IOException {
         public void checkRoles(RoleChecker roleChecker) throws SecurityException {
         }
     }
+
+    private static final long serialVersionUID = 1L;
 }

src/main/java/org/jvnet/hudson/plugins/port_allocator/PortAllocator.java

@@ -38,7 +38,7 @@ public class PortAllocator extends SimpleBuildWrapper
 {
     private static final Log log = LogFactory.getLog(PortAllocator.class);
 
-    public final List<PortType> ports = Lists.newArrayList();
+    protected final List<PortType> ports = Lists.newArrayList();
 
 	private String pool;
 	private final List<String> pools = Lists.newArrayList();
@@ -104,8 +104,9 @@ public void setUp(Context context, Run<?, ?> run, FilePath workspace, Launcher l
 
         Computer cur = workspace.toComputer();
         Map<String,Integer> prefPortMap = new HashMap<String,Integer>();
-        if (run.getPreviousBuild() != null) {
-            AllocatedPortAction prevAlloc = run.getPreviousBuild().getAction(AllocatedPortAction.class);
+	Run<?, ?> prevBuild  = run.getPreviousBuild();
+        if (prevBuild != null) {
+            AllocatedPortAction prevAlloc = prevBuild.getAction(AllocatedPortAction.class);
             if (prevAlloc != null) {
                 // try to assign ports assigned in previous build
                 prefPortMap = prevAlloc.getPreviousAllocatedPorts();

src/main/java/org/jvnet/hudson/plugins/port_allocator/PortTypeDescriptor.java

@@ -19,5 +19,5 @@ protected PortTypeDescriptor(Class<? extends PortType> clazz) {
     /**
      * All registered {@link PortTypeDescriptor}s.
      */
-    public static final List<PortTypeDescriptor> LIST = new ArrayList<PortTypeDescriptor>();
+    static final List<PortTypeDescriptor> LIST = new ArrayList<PortTypeDescriptor>();
 }

src/main/java/org/jvnet/hudson/plugins/port_allocator/TomcatShutdownPortType.java

@@ -11,13 +11,17 @@
 
 import java.io.IOException;
 import java.io.Serializable;
+import java.nio.charset.StandardCharsets;
 import java.net.Socket;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
+
 
 /**
  * Tomcat shutdown port.
  *
  * @author Kohsuke Kawaguchi
  */
+@SuppressFBWarnings(value="SE_INNER_CLASS")
 public class TomcatShutdownPortType  extends PortType {
     /**
      * Shutdown magic phrase.
@@ -57,7 +61,7 @@ public Void call() throws IOException {
                 }
 
                 try {
-                    s.getOutputStream().write(password.getBytes());
+                    s.getOutputStream().write(password.getBytes(StandardCharsets.UTF_8));
                     s.close();
                     taskListener.getLogger().println("Shutdown left-over Tomcat");
                 } catch (IOException x) {