mstump: description of idx in private functions #867
NimaSarajpoor
started this conversation in
General
Replies: 1 comment 1 reply
-
|
I think you're right. Though, I think it's more like: Is this better? |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
In module mstump.py:
The function
_mstumpcalls the function_compute_multi_Dwhich has the argumentidxwith the following description:The function
_mstumpalso calls the functioncore._compute_multi_PIthat has the same argumentidxwith the same description.However, I think this description might be incorrect. If
Tis multi-dimensional, i.e. 2D numpy array, where each row corresponds to one time series, then the description ofidxshould be:This is based on what I can see, regarding
idx, in the following lines of code:https://github.com/TDAmeritrade/stumpy/blob/76cb9806dec2d32f80ff20a5a3c484c34b7a54bf/stumpy/mstump.py#L800-L814
Beta Was this translation helpful? Give feedback.
All reactions