Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LQ in MWPTools #184

Open
Stemplar42 opened this issue Dec 10, 2024 · 7 comments
Open

LQ in MWPTools #184

Stemplar42 opened this issue Dec 10, 2024 · 7 comments
Labels
3rd party dependency Feature Request Feature request (doesn't stale)

Comments

@Stemplar42
Copy link

Stemplar42 commented Dec 10, 2024

Hello: I am using INAV 8.0.0 RC1 with MSP for RX and Telemetry. TX and RX are from Matek under mLRS mode.

My need is to see the LQ on screen along with the RSSI. I can only see RSS and it would be very useful to see the LQ and even the SNR (Signal to Noise Ratio) together.

Is this possible?

image

@stronnag
Copy link
Owner

Currently, mwp displays LQ when using CRSF for RC and RSSI otherwise, as this is what MSP2_INAV_ANALOG provides.
So unless there is a new MSP message to enable a consumer to get LQ etc., then this is not possible.

@b14ckyy
Copy link

b14ckyy commented Dec 10, 2024

Do you know if it would be feasible to extend MSP2_INAV_ANALOG or would that be 100% compatibility breaking? Just thinking if a new MSP message is needed.
A complete new message for LQ would be a bit overkill so maybe in the future we can think of a better way to do that without breaking anything.

@stronnag
Copy link
Owner

It has been considered acceptable to extend messages by appending fields (not inserting other than at the end). Then consumers can check the length to see of the extended data is available.

Otherwise the options would be:

  • A new message (eg) MSP2_INAV_ANALOG2 that just extends MSP2_INAV_ANALOG with new fields and the consumer can decide which to use
  • A new message MSP2_INAV_LQ_SNR that just gets LQ/SNR etc.

My preference would be to add the required fields to MSP2_INAV_ANALOG rather than create new messages and the consumer then having to decide which to use based on FC version.

@b14ckyy
Copy link

b14ckyy commented Dec 10, 2024

Actually: I have an idea for that I will discuss with Darren for a future version. We actually have the message for that. We have the MSP2_LINK_STATS message that came with 8.0. Right now its just to feed the FC with RC link information. But there would speak nothing against to request the same data back from the FC. Its all in there, technically even from other RC Link inputs like CRSF as they feed the same internal variables.

Probably both variants would be good. Extend MSP2_INAV_ANALOG just with LQ and maybe SNR, but also provide the option to use MSP2_LINK_STATS if someone wants to get the full spectrum of link information.

@Stemplar42
Copy link
Author

As a regular user, I appreciate the ideas you have for expanding the download of information from INAV to MWP. I look forward to your progress, I am very happy with MWP and I think it would be very useful to have it under MSP modality.

@b14ckyy
Copy link

b14ckyy commented Dec 10, 2024

as the Limitation is INAV here I opened a Request there. Guess we can close here for now unless stronnag want to keep it open for reference.

@Stemplar42
Copy link
Author

as the Limitation is INAV here I opened a Request there. Guess we can close here for now unless stronnag want to keep it open for reference.

Ok. For my part, I will be attentive to that INAV Request.

@stronnag stronnag added Feature Request Feature request (doesn't stale) 3rd party dependency labels Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd party dependency Feature Request Feature request (doesn't stale)
Projects
None yet
Development

No branches or pull requests

3 participants