Working inside linux #12
Conversation
|
|
|
well as i got through gdb that this project is using nativefiledialog, which currently doesnt support wayland so people using wayland might have problem here |
README.md
Outdated
| "name": "linux-clang-18", | ||
| "inherits": "default", | ||
| "cacheVariables": { | ||
| "CMAKE_C_COMPILER": "/usr/bin/clang-18", |
There was a problem hiding this comment.
Could you also change clang-18 to clang?
| [^1]: I like this term because it's hilarious for several reasons, but it's no joke! It has the **significantly faster glTF model loading speed than the other the viewers** I've tested. See [Performance Comparison](https://github.com/stripe2933/vk-gltf-viewer/blob/master/docs/performance-comparison.md) page for details. | ||
| [^2]: Applied for standard glTF 2.0 asset only. Asset with material related extensions may require additional draw calls for pipeline changing. | ||
| [^3]: On Apple GPU platform prior to the MoltenVK 1.2.11 (which enables the Metal Argument Buffer by default), [`maxPerStageDescriptorUpdateAfterBindStorageImages` is 8](https://vulkan.gpuinfo.org/displaycoreproperty.php?platform=macos&name=maxPerStageDescriptorUpdateAfterBindStorageImages&core=1.2). It limited the cubemap resoluton and prefilteredmap roughnesslevels. Instead, it can use `VK_AMD_shader_image_load_store_lod` extension to replace the descriptor indexing based cubemap mipmapping and prefilteredmap generation. | ||
| [^3]: On Apple GPU platform prior to the MoltenVK 1.2.11 (which enables the Metal Argument Buffer by default), [`maxPerStageDescriptorUpdateAfterBindStorageImages` is 8](https://vulkan.gpuinfo.org/displaycoreproperty.php?platform=macos&name=maxPerStageDescriptorUpdateAfterBindStorageImages&core=1.2). It limited the cubemap resoluton and prefilteredmap roughnesslevels. Instead, it can use `VK_AMD_shader_image_load_store_lod` extension to replace the descriptor indexing based cubemap mipmapping and prefilteredmap generation. |
There was a problem hiding this comment.
Why this line has been changed?
| brdfmapComputer.descriptorSetLayout.getPoolSize().getDescriptorPoolCreateInfo(), | ||
| }; | ||
|
|
||
| vk::DescriptorPoolCreateInfo descriptorPoolCreateInfo = brdfmapComputer.descriptorSetLayout.getPoolSize().getDescriptorPoolCreateInfo(); |
There was a problem hiding this comment.
This would not be work. vku::PoolSizes::getDescriptorPoolCreateInfo returns both vk::DescriptorPoolCreateInfo and std::vector<vk::DescriptorPoolSize> via vku::RefHolder (former references the latter), but store it into vk::DescriptorPoolCreateInfo will destroy the pool size vector.
You should pass vk::DescriptorPoolCreateFlagBits::eFreeDescriptorSet to the method by parameter and use the struct directly.
impl/vulkan/Frame.cpp
Outdated
| .getDescriptorPoolCreateInfo(), | ||
| }; | ||
|
|
||
| auto poolCreateInfo = |
|
|
||
| import std; | ||
|
|
||
| #define COMPILED_SHADER_DIR "shader" |
There was a problem hiding this comment.
Isn't it already defined by CMakeLists.txt?
Line 194 in 713156e
There was a problem hiding this comment.
Isn't it already defined by
CMakeLists.txt?Line 194 in 713156e
yeah sorry for not being careful temporarily put it there because i was getting error there while calling binary as ./build/vk-gltf-viewer
|
I'll work for NFD in Wayland support. |
|
Fix for NFD in Wayland merged in master branch. |
|
Reverting |
|
Closed as superseded by #31. |
2 participants
PR to get it properly working on linux