Skip to content

Remove vertx from KraftVersionChangeCreator class - #13094

Open
ShubhamRwt wants to merge 3 commits into
strimzi:mainfrom
ShubhamRwt:removeKraftVersion
Open

Remove vertx from KraftVersionChangeCreator class#13094
ShubhamRwt wants to merge 3 commits into
strimzi:mainfrom
ShubhamRwt:removeKraftVersion

Conversation

@ShubhamRwt

@ShubhamRwt ShubhamRwt commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Type of change

  • Refactoring

Description

This PR removes vertx completely from KraftVersionChangeCreator its associated test class
and uses the java classes instead. This PR will help in finishing #13066

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Update documentation
  • Update CHANGELOG.md (if present)
  • Reference relevant issue(s) and close them after merging
  • Write tests
  • Make sure all tests pass
  • Try your changes inside a Kubernetes cluster, not just from unit tests
  • AI assistance was used to create this PR (see the Strimzi AI policy)

Signed-off-by: ShubhamRwt <shubhamrwt02@gmail.com>
@snyk-io

snyk-io Bot commented Aug 24, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Signed-off-by: ShubhamRwt <shubhamrwt02@gmail.com>
@codecov

codecov Bot commented Aug 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.65%. Comparing base (5d231d4) to head (6ee2b6c).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13094      +/-   ##
============================================
- Coverage     80.68%   80.65%   -0.04%     
- Complexity     6613     6627      +14     
============================================
  Files           344      344              
  Lines         22780    22765      -15     
  Branches       3116     3116              
============================================
- Hits          18380    18360      -20     
- Misses         3181     3183       +2     
- Partials       1219     1222       +3     
Files with missing lines Coverage Δ
...r/operator/assembly/KRaftVersionChangeCreator.java 97.61% <100.00%> (ø)
...uster/operator/assembly/KafkaAssemblyOperator.java 84.47% <100.00%> (ø)

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ShubhamRwt
ShubhamRwt marked this pull request as ready for review August 25, 2026 08:05
@scholzj scholzj added this to the 1.3.0 milestone Aug 25, 2026
@scholzj

scholzj commented Aug 25, 2026

Copy link
Copy Markdown
Member

@ShubhamRwt Pro-tips ...

  • It is fine to open a PR as a Draft first. But GitHub does not send notifications when you mark it as ready for review. So you should ideally just comment on the PR with something like Hey folks, this PR is not read for review.
  • Please make sure to follow the PR template. Not all of the things apply for every PR, so you can just delete those that are not applicable. But surely some apply here as well ... relevant issues (Remove Vert.x from KafkaAssemblyOperator #13066 or Remove Vert.x from KafkaReconciler #13054 I guess), running the tests, trying that the code you wrote actually works, AI disclosure if applicable, etc.

@scholzj
scholzj requested review from scholzj and tinaselenge August 25, 2026 15:49
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.Mockito.when;

@ExtendWith(VertxExtension.class)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably add the timeout annotation as we do for other PRs?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done now

@ShubhamRwt

Copy link
Copy Markdown
Contributor Author

Hi @scholzj thanks for the tips...I will use them or my upcoming PR's. I tagged the issue in the PR description instead and didnt see through the checklist

@scholzj

scholzj commented Aug 25, 2026

Copy link
Copy Markdown
Member

Hi @scholzj thanks for the tips...I will use them or my upcoming PR's. I tagged the issue in the PR description instead and didnt see through the checklist

Tagging it in the description is fine. But you need to check the checkbox that you did it. Same for the other things. That is why the checkboxes are there to help to guide you through what you need to do before opening a PR. As I said, not all of them might apply such as CHANGELOG or documentation. But things such as trying your own code and running test apply almost always.

Signed-off-by: ShubhamRwt <shubhamrwt02@gmail.com>
@scholzj

scholzj commented Aug 26, 2026

Copy link
Copy Markdown
Member

/gha run pipeline=regression

@github-actions

github-actions Bot commented Aug 26, 2026

Copy link
Copy Markdown

⏳ System test verification started: link

The following 6 job(s) will be executed:

  • regression-brokers-and-security-amd64 (cncf-ubuntu-8-32-x86)
  • regression-operators-amd64 (cncf-ubuntu-8-32-x86)
  • regression-operands-amd64 (cncf-ubuntu-8-32-x86)
  • regression-brokers-and-security-arm64 (cncf-ubuntu-8-32-arm)
  • regression-operators-arm64 (cncf-ubuntu-8-32-arm)
  • regression-operands-arm64 (cncf-ubuntu-8-32-arm)

Tests will start after successful build completion.

@github-actions

Copy link
Copy Markdown

🎉 System test verification passed: link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants