Remove vertx from KraftVersionChangeCreator class - #13094
Conversation
Signed-off-by: ShubhamRwt <shubhamrwt02@gmail.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Signed-off-by: ShubhamRwt <shubhamrwt02@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13094 +/- ##
============================================
- Coverage 80.68% 80.65% -0.04%
- Complexity 6613 6627 +14
============================================
Files 344 344
Lines 22780 22765 -15
Branches 3116 3116
============================================
- Hits 18380 18360 -20
- Misses 3181 3183 +2
- Partials 1219 1222 +3
🚀 New features to boost your workflow:
|
|
@ShubhamRwt Pro-tips ...
|
| import static org.mockito.ArgumentMatchers.any; | ||
| import static org.mockito.Mockito.when; | ||
|
|
||
| @ExtendWith(VertxExtension.class) |
There was a problem hiding this comment.
You should probably add the timeout annotation as we do for other PRs?
|
Hi @scholzj thanks for the tips...I will use them or my upcoming PR's. I tagged the issue in the PR description instead and didnt see through the checklist |
Tagging it in the description is fine. But you need to check the checkbox that you did it. Same for the other things. That is why the checkboxes are there to help to guide you through what you need to do before opening a PR. As I said, not all of them might apply such as CHANGELOG or documentation. But things such as trying your own code and running test apply almost always. |
Signed-off-by: ShubhamRwt <shubhamrwt02@gmail.com>
|
/gha run pipeline=regression |
|
⏳ System test verification started: link The following 6 job(s) will be executed:
Tests will start after successful build completion. |
|
🎉 System test verification passed: link |
Type of change
Description
This PR removes vertx completely from
KraftVersionChangeCreatorits associated test classand uses the java classes instead. This PR will help in finishing #13066
Checklist
Please go through this checklist and make sure all applicable tasks have been done