Avoid adding empty properties objects in the CRDs - #13076
Merged
scholzj merged 1 commit intoAug 21, 2026
Conversation
Signed-off-by: Jakub Scholz <www@scholzj.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13076 +/- ##
=========================================
Coverage 80.68% 80.68%
- Complexity 6593 6594 +1
=========================================
Files 344 344
Lines 22787 22789 +2
Branches 3116 3117 +1
=========================================
+ Hits 18385 18388 +3
+ Misses 3183 3182 -1
Partials 1219 1219
🚀 New features to boost your workflow:
|
Member
Author
|
/gha run pipeline=regression |
|
⏳ System test verification started: link The following 6 job(s) will be executed:
Tests will start after successful build completion. |
|
🎉 System test verification passed: link |
ppatierno
approved these changes
Aug 21, 2026
tinaselenge
approved these changes
Aug 21, 2026
|
any chance we can get this released as a hotfix? 😁 |
Member
Author
|
@stefancaraiman-primedev Sorry, I personally do not have the capacity to do a patch release just because of this. Not sure if anyone else from the maintainers would have, but I doubt it. :-/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Empty objects in CRDs seem to be causing issues to Argo. This PR removes the empty
propertiesobjects that showed up in 1.2.0 release.This should resolve #13074.
Checklist