Skip to content

Avoid adding empty properties objects in the CRDs - #13076

Merged
scholzj merged 1 commit into
strimzi:mainfrom
scholzj:avoid-empty-properties-object-in-CRDs
Aug 21, 2026
Merged

Avoid adding empty properties objects in the CRDs#13076
scholzj merged 1 commit into
strimzi:mainfrom
scholzj:avoid-empty-properties-object-in-CRDs

Conversation

@scholzj

@scholzj scholzj commented Aug 20, 2026

Copy link
Copy Markdown
Member

Type of Change

  • Bugfix

Description

Empty objects in CRDs seem to be causing issues to Argo. This PR removes the empty properties objects that showed up in 1.2.0 release.

This should resolve #13074.

Checklist

  • Reference relevant issue(s) and close them after merging
  • Write tests
  • Make sure all tests pass

Signed-off-by: Jakub Scholz <www@scholzj.com>
@scholzj scholzj added this to the 1.3.0 milestone Aug 20, 2026
@scholzj
scholzj requested a review from a team August 20, 2026 19:55
@snyk-io

snyk-io Bot commented Aug 20, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@codecov

codecov Bot commented Aug 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.68%. Comparing base (e8b43c2) to head (2370028).

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #13076   +/-   ##
=========================================
  Coverage     80.68%   80.68%           
- Complexity     6593     6594    +1     
=========================================
  Files           344      344           
  Lines         22787    22789    +2     
  Branches       3116     3117    +1     
=========================================
+ Hits          18385    18388    +3     
+ Misses         3183     3182    -1     
  Partials       1219     1219           
Files with missing lines Coverage Δ
...ain/java/io/strimzi/crdgenerator/CrdGenerator.java 58.58% <100.00%> (+0.11%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scholzj

scholzj commented Aug 20, 2026

Copy link
Copy Markdown
Member Author

/gha run pipeline=regression

@github-actions

github-actions Bot commented Aug 20, 2026

Copy link
Copy Markdown

⏳ System test verification started: link

The following 6 job(s) will be executed:

  • regression-brokers-and-security-amd64 (cncf-ubuntu-8-32-x86)
  • regression-operators-amd64 (cncf-ubuntu-8-32-x86)
  • regression-operands-amd64 (cncf-ubuntu-8-32-x86)
  • regression-brokers-and-security-arm64 (cncf-ubuntu-8-32-arm)
  • regression-operators-arm64 (cncf-ubuntu-8-32-arm)
  • regression-operands-arm64 (cncf-ubuntu-8-32-arm)

Tests will start after successful build completion.

@github-actions

Copy link
Copy Markdown

🎉 System test verification passed: link

@scholzj
scholzj merged commit f7b4cc3 into strimzi:main Aug 21, 2026
31 checks passed
@scholzj
scholzj deleted the avoid-empty-properties-object-in-CRDs branch August 21, 2026 10:05
@stefancaraiman-primedev

Copy link
Copy Markdown

any chance we can get this released as a hotfix? 😁

@scholzj

scholzj commented Aug 25, 2026

Copy link
Copy Markdown
Member Author

@stefancaraiman-primedev Sorry, I personally do not have the capacity to do a patch release just because of this. Not sure if anyone else from the maintainers would have, but I doubt it. :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Argo Out of Sync due to empty properties under Kafka CRD.

4 participants