From b9488c0193617b3fab18a8c445ed79a437bab175 Mon Sep 17 00:00:00 2001 From: Lari Hotari Date: Fri, 22 Jul 2022 20:58:37 +0300 Subject: [PATCH] =?UTF-8?q?Rename=20"GC=20Pauses"=20to=20"GC=20Time"=20in?= =?UTF-8?q?=20Pulsar=20JVM=20dashboards=C2=AC?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - source metric is not about GC pauses.¬ - the source metric is "jvm_gc_collection_seconds_sum" which is not the same as "GC pause"¬ - The metric is defined in Prometheus Java client¬ - "Time spent in a given JVM garbage collector in seconds."¬ - source code is https://github.com/prometheus/client_java/blob/e68daf23336eb5de7856df406eb1d497f51ad3be/simpleclient_hotspot/src/main/java/io/prometheus/client/hotspot/GarbageCollectorExports.java#L53¬ - calls GarbageCollectorMXBean.getCollectionTime()¬ - Javadoc https://docs.oracle.com/en/java/javase/11/docs/api/java.management/java/lang/management/GarbageCollectorMXBean.html#getCollectionTime()¬ "Returns the approximate accumulated collection elapsed time in milliseconds."¬ - Stackoverflow Q&A: https://stackoverflow.com/a/44686539¬ --- dashboards.kubernetes/jvm.json | 2 +- dashboards.template/jvm.json.j2 | 2 +- dashboards/jvm.json | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dashboards.kubernetes/jvm.json b/dashboards.kubernetes/jvm.json index a8af526..6b99401 100644 --- a/dashboards.kubernetes/jvm.json +++ b/dashboards.kubernetes/jvm.json @@ -428,7 +428,7 @@ "thresholds": [], "timeFrom": null, "timeShift": null, - "title": "GC Pauses", + "title": "GC Time", "tooltip": { "shared": true, "sort": 0, diff --git a/dashboards.template/jvm.json.j2 b/dashboards.template/jvm.json.j2 index 1686e00..1f2900f 100644 --- a/dashboards.template/jvm.json.j2 +++ b/dashboards.template/jvm.json.j2 @@ -437,7 +437,7 @@ This will make graph ledgends display the pod name instead of IP and port inform "thresholds": [], "timeFrom": null, "timeShift": null, - "title": "GC Pauses", + "title": "GC Time", "tooltip": { "shared": true, "sort": 0, diff --git a/dashboards/jvm.json b/dashboards/jvm.json index f10e148..76939d1 100644 --- a/dashboards/jvm.json +++ b/dashboards/jvm.json @@ -428,7 +428,7 @@ "thresholds": [], "timeFrom": null, "timeShift": null, - "title": "GC Pauses", + "title": "GC Time", "tooltip": { "shared": true, "sort": 0,