Skip to content

Commit 5cf67d0

Browse files
committed
Rename "GC Pauses" to "GC Collection Time" in Pulsar JVM dashboards¬
- source metric is not about GC pauses.¬ - the source metric is "jvm_gc_collection_seconds_sum" which is not the same as "GC pause"¬ - The metric is defined in Prometheus Java client¬ - "Time spent in a given JVM garbage collector in seconds."¬ - source code is https://github.com/prometheus/client_java/blob/e68daf23336eb5de7856df406eb1d497f51ad3be/simpleclient_hotspot/src/main/java/io/prometheus/client/hotspot/GarbageCollectorExports.java#L53¬ - calls GarbageCollectorMXBean.getCollectionTime()¬ - Javadoc https://docs.oracle.com/en/java/javase/11/docs/api/java.management/java/lang/management/GarbageCollectorMXBean.html#getCollectionTime()¬ "Returns the approximate accumulated collection elapsed time in milliseconds."¬ - Stackoverflow Q&A: https://stackoverflow.com/a/44686539¬
1 parent 1c6c558 commit 5cf67d0

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

dashboards.kubernetes/jvm.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -428,7 +428,7 @@
428428
"thresholds": [],
429429
"timeFrom": null,
430430
"timeShift": null,
431-
"title": "GC Pauses",
431+
"title": "GC Collection Time",
432432
"tooltip": {
433433
"shared": true,
434434
"sort": 0,

dashboards.template/jvm.json.j2

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -437,7 +437,7 @@ This will make graph ledgends display the pod name instead of IP and port inform
437437
"thresholds": [],
438438
"timeFrom": null,
439439
"timeShift": null,
440-
"title": "GC Pauses",
440+
"title": "GC Collection Time",
441441
"tooltip": {
442442
"shared": true,
443443
"sort": 0,

dashboards/jvm.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -428,7 +428,7 @@
428428
"thresholds": [],
429429
"timeFrom": null,
430430
"timeShift": null,
431-
"title": "GC Pauses",
431+
"title": "GC Collection Time",
432432
"tooltip": {
433433
"shared": true,
434434
"sort": 0,

0 commit comments

Comments
 (0)