Skip to content

Commit aef56fd

Browse files
committed
fix: remove joinABPAsync reference
With ABP mode, an end device skips the join procedure and so it is not blocking. As explained in the documentation of the joinABP: "An ABP join returns immediately, it does not need to wait for the network, so there is no separate non-blocking/async version of this method." Fixes #28 Signed-off-by: Frederic Pillon <[email protected]>
1 parent 5029c90 commit aef56fd

File tree

3 files changed

+2
-3
lines changed

3 files changed

+2
-3
lines changed

examples/ScheduledAsync/ScheduledAsync.ino

+1-1
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ void start_join()
9797
//modem.setDevAddr("00000000");
9898
//modem.setNwkSKey("00000000000000000000000000000000");
9999
//modem.setAppSKey("00000000000000000000000000000000");
100-
//modem.joinABPAsync();
100+
//modem.joinABP();
101101

102102
lora_state = JOINING;
103103
}

examples/SimpleAsync/SimpleAsync.ino

+1-1
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ void setup()
5252
//modem.setDevAddr("00000000");
5353
//modem.setNwkSKey("00000000000000000000000000000000");
5454
//modem.setAppSKey("00000000000000000000000000000000");
55-
//modem.joinABPAsync();
55+
//modem.joinABP();
5656

5757
wait_for_idle();
5858

keywords.txt

-1
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@ joinOTAAAsync KEYWORD2
6060
setDevAddr KEYWORD2
6161
setNwkSKey KEYWORD2
6262
setAppSKey KEYWORD2
63-
joinABPAsync KEYWORD2
6463
endPacketAsync KEYWORD2
6564
getDownlinkPort KEYWORD2
6665
setMaintainNeededCallback KEYWORD2

0 commit comments

Comments
 (0)