Revert parts of "Add more debug output"

This reverts commit 7611d5c.

Some of this debug output caused problems with RX timing. This reverts
the changes to STM32CubeWL, preparing to re-add the non-problematic
parts in another commit (to keep the changes made to upstream more
contained and easier to track).

This also reverts the RFSwitch debug output in the BSP, which was too
verbose anyway.

Author: matthijskooijman

src/BSP/radio_board_if.c

@@ -36,7 +36,6 @@
 
 /* Includes ------------------------------------------------------------------*/
 #include "radio_board_if.h"
-#include "mw_log_conf.h"
 #include "Arduino.h"
 
 /* Board configuration --------------------------------------------------------*/
@@ -106,22 +105,9 @@ int32_t RBI_DeInit(void)
   return 0;
 }
 
-static const char *ConfigToString(RBI_Switch_TypeDef Config)
-{
-  switch (Config) {
-    case RBI_SWITCH_OFF: return "OFF";
-    case RBI_SWITCH_RX: return "RX";
-    case RBI_SWITCH_RFO_LP: return "RFO_LP";
-    case RBI_SWITCH_RFO_HP: return "RFO_HP";
-    default: return "INVALID";
-  }
-}
-
 int32_t RBI_ConfigRFSwitch(RBI_Switch_TypeDef Config)
 {
-  MW_LOG(TS_OFF, VLEVEL_M, "Configuring RFSwitch for %s\r\n", ConfigToString(Config));
   for (unsigned i = 0; i < LORAWAN_RFSWITCH_PIN_COUNT; ++i) {
-    MW_LOG(TS_OFF, VLEVEL_M, "> Setting pin %u to %u\r\n", lorawan_rfswitch_pins[i], lorawan_rfswitch_values[Config][i]);
     digitalWrite(lorawan_rfswitch_pins[i], lorawan_rfswitch_values[Config][i]);
   }
   return 0;

src/STM32CubeWL/LoRaWAN/Mac/LoRaMac.c

@@ -1070,11 +1070,6 @@ static void ProcessRadioRxDone( void )
     AddressIdentifier_t addrID = UNICAST_DEV_ADDR;
     FCntIdentifier_t fCntID;
 
-    MW_LOG( TS_ON, VLEVEL_M, "RX: ");
-    for (size_t i = 0; i < RxDoneParams.Size; ++i)
-        MW_LOG( TS_ON, VLEVEL_M, "%02x", RxDoneParams.Payload[i]);
-    MW_LOG( TS_ON, VLEVEL_M, "\r\n");
-
 #if ( defined( LORAMAC_VERSION ) && ( LORAMAC_VERSION == 0x01000400 ))
     LoRaMacRadioEvents.Events.RxProcessPending = 0;
 #endif /* LORAMAC_VERSION */

src/STM32CubeWL/SubGHz_Phy/stm32_radio_driver/radio.c

@@ -830,15 +830,6 @@ static void RadioSetRxConfig( RadioModems_t modem, uint32_t bandwidth,
 #if (RADIO_SIGFOX_ENABLE == 1)
     uint8_t modReg;
 #endif
-    MW_LOG( TS_ON, VLEVEL_M,
-        "Setting RX Config: modem=%s, bandwidth=%u, datarate=%u, coderate=%u bandwithAfc=%u, preambleLen=%u, symbTimeout=%u, fixLen=%u, payloadLen=%u, crcOn=%u, freqHopOn=%u, hopPeriod=%u, iqInverted=%u, rxContinuous=%u\r\n",
-        modem == MODEM_FSK ? "MODEM_FSK" : (modem == MODEM_LORA ? "MODEM_LORA" : "?"),
-        (unsigned)bandwidth, (unsigned)datarate, (unsigned)coderate,
-        (unsigned)bandwidthAfc, (unsigned)preambleLen,
-        (unsigned)symbTimeout, (unsigned)fixLen, (unsigned)payloadLen,
-        (unsigned)crcOn, (unsigned)freqHopOn, (unsigned)hopPeriod,
-        (unsigned)iqInverted, (unsigned)rxContinuous
-    );
     SubgRf.RxContinuous = rxContinuous;
     RFW_DeInit(); /* ST_WORKAROUND: Switch Off FwPacketDecoding by default */
     if( rxContinuous == true )
@@ -1021,15 +1012,6 @@ static void RadioSetTxConfig( RadioModems_t modem, int8_t power, uint32_t fdev,
                               uint8_t hopPeriod, bool iqInverted, uint32_t timeout )
 {
     RFW_DeInit(); /* ST_WORKAROUND: Switch Off FwPacketDecoding by default */
-    MW_LOG( TS_ON, VLEVEL_M,
-        "Setting TX Config: modem=%s, power=%u, fdev=%u, bandwidth=%u, datarate=%u, coderate=%u preambleLen=%u, fixLen=%u, crcOn=%u, freqHopOn=%u, hopPeriod=%u, iqInverted=%u, timeout=%u\r\n",
-        modem == MODEM_FSK ? "MODEM_FSK" : (modem == MODEM_LORA ? "MODEM_LORA" : "?"),
-        (unsigned)power, (unsigned)fdev, (unsigned)bandwidth,
-        (unsigned)datarate, (unsigned)coderate, (unsigned)preambleLen,
-        (unsigned)fixLen, (unsigned)crcOn, (unsigned)freqHopOn,
-        (unsigned)hopPeriod, (unsigned)iqInverted, (unsigned)timeout
-    );
-
     switch( modem )
     {
         case MODEM_FSK:
@@ -1290,11 +1272,6 @@ static void RadioSend( uint8_t *buffer, uint8_t size )
                             IRQ_RADIO_NONE );
     /* ST_WORKAROUND_END */
 
-    MW_LOG( TS_ON, VLEVEL_M, "TX:");
-    for (size_t i = 0; i < size; ++i)
-        MW_LOG( TS_ON, VLEVEL_M, " %02x", buffer[i]);
-    MW_LOG( TS_ON, VLEVEL_M, "\r\n");
-
     /* ST_WORKAROUND_BEGIN : Set the debug pin and update the radio switch */
     /* Set DBG pin */
     DBG_GPIO_RADIO_TX( SET );
@@ -1412,7 +1389,6 @@ static void RadioStandby( void )
 
 static void RadioRx( uint32_t timeout )
 {
-    MW_LOG( TS_ON, VLEVEL_M, "Starting RX\r\n");
     if( 1UL == RFW_Is_Init( ) )
     {
         RFW_ReceiveInit( );