Skip to content

EthernetClient BUG #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TingRuazhang opened this issue Feb 7, 2025 · 1 comment · Fixed by #94
Closed

EthernetClient BUG #93

TingRuazhang opened this issue Feb 7, 2025 · 1 comment · Fixed by #94
Labels
bug 🐛 Something isn't working
Milestone

Comments

@TingRuazhang
Copy link
Contributor

TingRuazhang commented Feb 7, 2025

void EthernetClient::stop()
{
if (_tcp_client == NULL) {
return;
}

// close tcp connection if not closed yet
if (status() != TCP_CLOSING) {
tcp_connection_close(_tcp_client->pcb, _tcp_client);
}
mem_free(_tcp_client);
}

In this function, memefree (_tcp_cient);, After release, the _tcp_cient was not set to NULL, which caused an exception when TCPClient was reconnected. After adding it, it worked normally. Please fix this issue

@fpistm
Copy link
Member

fpistm commented Feb 7, 2025

Hi @q1098401179
feel free to provide a PR it's a community project.

@fpistm fpistm linked a pull request Feb 7, 2025 that will close this issue
@fpistm fpistm added the bug 🐛 Something isn't working label Feb 7, 2025
@fpistm fpistm added this to the 1.4.1/1.5.0 milestone Feb 7, 2025
@fpistm fpistm closed this as completed in #94 Feb 7, 2025
@github-project-automation github-project-automation bot moved this from To do to Done in STM32duino libraries Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

2 participants