Skip to content

Commit 60bbf39

Browse files
authored
Merge pull request #74 from fpistm/setConnectionTimeout
fix(client): setTimeout shadows Stream.setTimeout
2 parents aa55112 + 6d46fb0 commit 60bbf39

File tree

3 files changed

+15
-6
lines changed

3 files changed

+15
-6
lines changed

keywords.txt

+11-2
Original file line numberDiff line numberDiff line change
@@ -24,18 +24,27 @@ peek KEYWORD2
2424
flush KEYWORD2
2525
stop KEYWORD2
2626
connected KEYWORD2
27+
accept KEYWORD2
2728
begin KEYWORD2
29+
beginMulticast KEYWORD2
2830
beginPacket KEYWORD2
2931
endPacket KEYWORD2
3032
parsePacket KEYWORD2
3133
remoteIP KEYWORD2
3234
remotePort KEYWORD2
3335
getSocketNumber KEYWORD2
3436
localIP KEYWORD2
35-
MACAddress KEYWORD2
37+
localPort KEYWORD2
3638
maintain KEYWORD2
39+
linkStatus KEYWORD2
40+
MACAddress KEYWORD2
41+
subnetMask KEYWORD2
42+
gatewayIP KEYWORD2
43+
dnsServerIP KEYWORD2
44+
setConnectionTimeout KEYWORD2
3745

3846
#######################################
3947
# Constants (LITERAL1)
4048
#######################################
41-
49+
LinkON LITERAL1
50+
LinkOFF LITERAL1

src/EthernetClient.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ int EthernetClient::connect(IPAddress ip, uint16_t port)
7676
startTime = millis();
7777
while (_tcp_client->state == TCP_NONE) {
7878
stm32_eth_scheduler();
79-
if ((_tcp_client->state == TCP_CLOSING) || ((millis() - startTime) >= _timeout)) {
79+
if ((_tcp_client->state == TCP_CLOSING) || ((millis() - startTime) >= _connectionTimeout)) {
8080
stop();
8181
return 0;
8282
}

src/EthernetClient.h

+3-3
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,9 @@ class EthernetClient : public Client {
5252
{
5353
return (_tcp_client->pcb->remote_port);
5454
};
55-
void setTimeout(uint16_t timeout)
55+
void setConnectionTimeout(uint16_t timeout)
5656
{
57-
_timeout = timeout;
57+
_connectionTimeout = timeout;
5858
}
5959

6060
friend class EthernetServer;
@@ -63,7 +63,7 @@ class EthernetClient : public Client {
6363

6464
private:
6565
struct tcp_struct *_tcp_client;
66-
uint16_t _timeout = 10000;
66+
uint16_t _connectionTimeout = 10000;
6767
};
6868

6969
#endif

0 commit comments

Comments
 (0)