Skip to content

Typo in serial.rs #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tytouf opened this issue Apr 6, 2020 · 6 comments
Closed

Typo in serial.rs #92

tytouf opened this issue Apr 6, 2020 · 6 comments

Comments

@tytouf
Copy link

tytouf commented Apr 6, 2020

I encountered what seems to be a typo in serial.rs when building with feature "io-STM32L021"

index 190c40d..7b46ea9 100755
--- a/src/serial.rs
+++ b/src/serial.rs
@@ -173,7 +173,7 @@ impl_pins!(
     PA0, AF6, LPUART1, RxPin;
     PA1, AF6, LPUART1, TxPin;
     PA2, AF4, USART2, TxPin;
-    PA2, AF6, LPUART1, TxPin,
+    PA2, AF6, LPUART1, TxPin;
     PA3, AF4, USART2, RxPin;
     PA3, AF6, LPUART1, RxPin;
     PA4, AF6, LPUART1, TxPin;
@dbrgn
Copy link
Contributor

dbrgn commented Apr 6, 2020

That does indeed look like a typo! Sorry for that. We should make sure that all 4 IO features are tested in CI 😕

@dbrgn
Copy link
Contributor

dbrgn commented Apr 6, 2020

I'll provide a fix for this case and the CI.

Edit: #93 and #94.

@tytouf
Copy link
Author

tytouf commented Apr 6, 2020

Thanks!

@tytouf
Copy link
Author

tytouf commented Apr 6, 2020

On a separate note I was able to toggle a pin and output on the uart very quickly: good job and thank you for the work on this crate!

@dbrgn
Copy link
Contributor

dbrgn commented Apr 7, 2020

This should now be fixed on master, so the issue can be closed.

@arkorobotics maybe there should be a patch release on crates.io since 0.6.0 breaks compilation for some targets?

@arkorobotics
Copy link
Member

Done! Released v0.6.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants