Fix transfer-hpa-ownership panic when hpa name not provided (kedacore#7260)

* chore: renormalize line endings

Signed-off-by: James Williams <jamesleighwilliams@gmail.com>

* fix: nil pointer when transfer-hpa-ownership is true but hpa name not specified (kedacore#7254)

Signed-off-by: James Williams <jamesleighwilliams@gmail.com>

* update changelog

Signed-off-by: James Williams <jamesleighwilliams@gmail.com>

* revert vendor changes

Signed-off-by: James Williams <jamesleighwilliams@gmail.com>

---------

Signed-off-by: James Williams <jamesleighwilliams@gmail.com>

Author: jameswilliams1

CHANGELOG.md

@@ -77,6 +77,7 @@ To learn more about active deprecations, we recommend checking [GitHub Discussio
 
 ### Fixes
 
+- **General**: Fix nil reference panic when transfer-hpa-ownership is set but no hpa name is provided ([#7254](https://github.com/kedacore/keda/issues/7254))
 - **General**: Fix race condition in paused-replicas annotation causing ScaledObject to get stuck ([#7231](https://github.com/kedacore/keda/issues/7231))
 - **General**: Use TriggerError when all ScaledJob triggers fail ([#7205](https://github.com/kedacore/keda/pull/7205))
 - **ActiveMQ Scaler**: Correct parse error ActiveMQ ([#7245](https://github.com/kedacore/keda/pull/7245))

apis/keda/v1alpha1/scaledobject_webhook.go

@@ -277,9 +277,15 @@ func verifyHpas(incomingSo *ScaledObject, action string, _ bool) error {
 			}
 
 			if !owned {
-				if incomingSo.Annotations[ScaledObjectTransferHpaOwnershipAnnotation] == "true" &&
-					incomingSo.Spec.Advanced.HorizontalPodAutoscalerConfig.Name == hpa.Name {
-					scaledobjectlog.Info(fmt.Sprintf("%s hpa ownership being transferred to %s", hpa.Name, incomingSo.Name))
+				if incomingSo.Annotations[ScaledObjectTransferHpaOwnershipAnnotation] == "true" {
+					if incomingSo.Spec.Advanced != nil && incomingSo.Spec.Advanced.HorizontalPodAutoscalerConfig != nil && incomingSo.Spec.Advanced.HorizontalPodAutoscalerConfig.Name == hpa.Name {
+						scaledobjectlog.Info(fmt.Sprintf("%s hpa ownership being transferred to %s", hpa.Name, incomingSo.Name))
+					} else {
+						err = fmt.Errorf("the existing hpa '%s' for workload '%s' of type '%s' must be specified by name in advanced settings to enable ownership transfer", hpa.Name, incomingSo.Spec.ScaleTargetRef.Name, incomingSoGvkr.GVKString())
+						scaledobjectlog.Error(err, "validation error")
+						metricscollector.RecordScaledObjectValidatingErrors(incomingSo.Namespace, action, "transfer-ownership-missing-hpa-name")
+						return err
+					}
 				} else {
 					err = fmt.Errorf("the workload '%s' of type '%s' is already managed by the hpa '%s'", incomingSo.Spec.ScaleTargetRef.Name, incomingSoGvkr.GVKString(), hpa.Name)
 					scaledobjectlog.Error(err, "validation error")

apis/keda/v1alpha1/scaledobject_webhook_test.go

@@ -290,10 +290,10 @@ var _ = It("should validate the so creation when the fallback is configured, and
 	}).Should(HaveOccurred())
 })
 
-var _ = It("shouldn't validate the so creation when there is another unmanaged hpa and so has transfer-hpa-ownership activated", func() {
+var _ = It("should validate the so creation when there is another unmanaged hpa and so has transfer-hpa-ownership activated and the name is specified", func() {
 
-	hpaName := "test-unmanaged-hpa-ownership"
-	namespaceName := "unmanaged-hpa-ownership"
+	hpaName := "test-unmanaged-hpa-ownership-with-name"
+	namespaceName := "unmanaged-hpa-ownership-with-name"
 	namespace := createNamespace(namespaceName)
 	hpa := createHpa(hpaName, namespaceName, workloadName, "apps/v1", "Deployment", nil)
 	so := createScaledObject(soName, namespaceName, workloadName, "apps/v1", "Deployment", false, map[string]string{ScaledObjectTransferHpaOwnershipAnnotation: "true"}, hpaName)
@@ -309,6 +309,25 @@ var _ = It("shouldn't validate the so creation when there is another unmanaged h
 	}).ShouldNot(HaveOccurred())
 })
 
+var _ = It("shouldn't validate the so creation when there is another unmanaged hpa and so has transfer-hpa-ownership activated but no name specified", func() {
+
+	hpaName := "test-unmanaged-hpa-ownership-without-name"
+	namespaceName := "unmanaged-hpa-ownership-without-name"
+	namespace := createNamespace(namespaceName)
+	hpa := createHpa(hpaName, namespaceName, workloadName, "apps/v1", "Deployment", nil)
+	so := createScaledObject(soName, namespaceName, workloadName, "apps/v1", "Deployment", false, map[string]string{ScaledObjectTransferHpaOwnershipAnnotation: "true"}, "")
+
+	err := k8sClient.Create(context.Background(), namespace)
+	Expect(err).ToNot(HaveOccurred())
+
+	err = k8sClient.Create(context.Background(), hpa)
+	Expect(err).ToNot(HaveOccurred())
+
+	Eventually(func() error {
+		return k8sClient.Create(context.Background(), so)
+	}).Should(HaveOccurred())
+})
+
 var _ = It("shouldn't validate the so creation when hpa has shared-ownership unactivated", func() {
 
 	hpaName := "test-hpa-disabled-validation-by-hpa-ownership"