Skip to content

Commit 0ecc486

Browse files
saschanazsaschanaz
authored
BREAKING CHANGE: drop creator support (jsdom#101)
1 parent 4f1aab4 commit 0ecc486

33 files changed

+36
-103
lines changed

‎README.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -358,7 +358,6 @@ An operation looks like this:
358358
"type": "operation",
359359
"getter": false,
360360
"setter": false,
361-
"creator": false,
362361
"deleter": false,
363362
"static": false,
364363
"stringifier": false,
@@ -392,7 +391,6 @@ The fields are as follows:
392391
* `type`: Always "operation".
393392
* `getter`: True if a getter operation.
394393
* `setter`: True if a setter operation.
395-
* `creator`: True if a creator operation.
396394
* `deleter`: True if a deleter operation.
397395
* `static`: True if a static operation.
398396
* `stringifier`: True if a stringifier operation.
@@ -471,7 +469,6 @@ Iterator members look like this
471469
"type": "iterator",
472470
"getter": false,
473471
"setter": false,
474-
"creator": false,
475472
"deleter": false,
476473
"static": false,
477474
"stringifier": false,

‎lib/webidl2.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -573,7 +573,6 @@
573573
type: "operation",
574574
getter: false,
575575
setter: false,
576-
creator: false,
577576
deleter: false,
578577
"static": false,
579578
stringifier: false
@@ -582,11 +581,10 @@
582581
all_ws();
583582
if (consume(ID, "getter")) ret.getter = true;
584583
else if (consume(ID, "setter")) ret.setter = true;
585-
else if (consume(ID, "creator")) ret.creator = true;
586584
else if (consume(ID, "deleter")) ret.deleter = true;
587585
else break;
588586
}
589-
if (ret.getter || ret.setter || ret.creator || ret.deleter) {
587+
if (ret.getter || ret.setter || ret.deleter) {
590588
all_ws();
591589
ret.idlType = return_type();
592590
operation_rest(ret, store);
@@ -800,7 +798,6 @@
800798
type: "operation",
801799
getter: false,
802800
setter: false,
803-
creator: false,
804801
deleter: false,
805802
"static": false,
806803
stringifier: false

‎test/invalid/idl/setter-creator.widl

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
// Extracted from http://dev.w3.org/2006/webapi/WebIDL/ on 2011-05-06
2+
interface OrderedMap {
3+
setter creator void set(DOMString name, any value);
4+
};

‎test/invalid/json/setter-creator.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
{
2+
"message": "Invalid operation",
3+
"line": 3
4+
}

‎test/syntax/idl/indexed-properties.widl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,6 @@ interface OrderedMap {
77
deleter void removeByIndex(unsigned long index);
88

99
getter any get(DOMString name);
10-
setter creator void set(DOMString name, any value);
10+
setter void set(DOMString name, any value);
1111
deleter void remove(DOMString name);
12-
};
12+
};

‎test/syntax/json/allowany.json

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
"type": "operation",
99
"getter": false,
1010
"setter": false,
11-
"creator": false,
1211
"deleter": false,
1312
"static": false,
1413
"stringifier": false,
@@ -27,7 +26,6 @@
2726
"type": "operation",
2827
"getter": false,
2928
"setter": false,
30-
"creator": false,
3129
"deleter": false,
3230
"static": false,
3331
"stringifier": false,
@@ -60,7 +58,6 @@
6058
"type": "operation",
6159
"getter": false,
6260
"setter": false,
63-
"creator": false,
6461
"deleter": false,
6562
"static": false,
6663
"stringifier": false,
@@ -99,4 +96,4 @@
9996
"inheritance": null,
10097
"extAttrs": []
10198
}
102-
]
99+
]

‎test/syntax/json/callback.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@
3535
"type": "operation",
3636
"getter": false,
3737
"setter": false,
38-
"creator": false,
3938
"deleter": false,
4039
"static": false,
4140
"stringifier": false,
@@ -108,4 +107,4 @@
108107
],
109108
"extAttrs": []
110109
}
111-
]
110+
]

‎test/syntax/json/enum.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@
5050
"type": "operation",
5151
"getter": false,
5252
"setter": false,
53-
"creator": false,
5453
"deleter": false,
5554
"static": false,
5655
"stringifier": false,
@@ -106,4 +105,4 @@
106105
],
107106
"extAttrs": []
108107
}
109-
]
108+
]

‎test/syntax/json/equivalent-decl.json

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
"type": "operation",
2525
"getter": true,
2626
"setter": false,
27-
"creator": false,
2827
"deleter": false,
2928
"static": false,
3029
"stringifier": false,
@@ -57,7 +56,6 @@
5756
"type": "operation",
5857
"getter": false,
5958
"setter": true,
60-
"creator": false,
6159
"deleter": false,
6260
"static": false,
6361
"stringifier": false,
@@ -128,7 +126,6 @@
128126
"type": "operation",
129127
"getter": false,
130128
"setter": false,
131-
"creator": false,
132129
"deleter": false,
133130
"static": false,
134131
"stringifier": false,
@@ -161,7 +158,6 @@
161158
"type": "operation",
162159
"getter": false,
163160
"setter": false,
164-
"creator": false,
165161
"deleter": false,
166162
"static": false,
167163
"stringifier": false,
@@ -207,7 +203,6 @@
207203
"type": "operation",
208204
"getter": true,
209205
"setter": false,
210-
"creator": false,
211206
"deleter": false,
212207
"static": false,
213208
"stringifier": false,
@@ -240,7 +235,6 @@
240235
"type": "operation",
241236
"getter": false,
242237
"setter": true,
243-
"creator": false,
244238
"deleter": false,
245239
"static": false,
246240
"stringifier": false,
@@ -286,4 +280,4 @@
286280
"inheritance": null,
287281
"extAttrs": []
288282
}
289-
]
283+
]

‎test/syntax/json/generic.json

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
"type": "operation",
99
"getter": false,
1010
"setter": false,
11-
"creator": false,
1211
"deleter": false,
1312
"static": false,
1413
"stringifier": false,
@@ -76,7 +75,6 @@
7675
"type": "operation",
7776
"getter": false,
7877
"setter": false,
79-
"creator": false,
8078
"deleter": false,
8179
"static": false,
8280
"stringifier": false,
@@ -101,7 +99,6 @@
10199
"type": "operation",
102100
"getter": false,
103101
"setter": false,
104-
"creator": false,
105102
"deleter": false,
106103
"static": false,
107104
"stringifier": false,
@@ -135,7 +132,6 @@
135132
"type": "operation",
136133
"getter": false,
137134
"setter": false,
138-
"creator": false,
139135
"deleter": false,
140136
"static": false,
141137
"stringifier": false,
@@ -160,4 +156,4 @@
160156
"inheritance": "Event",
161157
"extAttrs": []
162158
}
163-
]
159+
]

‎test/syntax/json/getter-setter.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
"type": "operation",
2525
"getter": true,
2626
"setter": false,
27-
"creator": false,
2827
"deleter": false,
2928
"static": false,
3029
"stringifier": false,
@@ -57,7 +56,6 @@
5756
"type": "operation",
5857
"getter": false,
5958
"setter": true,
60-
"creator": false,
6159
"deleter": false,
6260
"static": false,
6361
"stringifier": false,
@@ -103,4 +101,4 @@
103101
"inheritance": null,
104102
"extAttrs": []
105103
}
106-
]
104+
]

‎test/syntax/json/identifier-qualified-names.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
"type": "operation",
2121
"getter": false,
2222
"setter": false,
23-
"creator": false,
2423
"deleter": false,
2524
"static": false,
2625
"stringifier": false,
@@ -53,7 +52,6 @@
5352
"type": "operation",
5453
"getter": true,
5554
"setter": false,
56-
"creator": false,
5755
"deleter": false,
5856
"static": false,
5957
"stringifier": false,
@@ -136,7 +134,6 @@
136134
"type": "operation",
137135
"getter": false,
138136
"setter": false,
139-
"creator": false,
140137
"deleter": false,
141138
"static": false,
142139
"stringifier": false,

‎test/syntax/json/implements.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@
3333
"type": "operation",
3434
"getter": false,
3535
"setter": false,
36-
"creator": false,
3736
"deleter": false,
3837
"static": false,
3938
"stringifier": false,
@@ -98,4 +97,4 @@
9897
"implements": "EventTarget",
9998
"extAttrs": []
10099
}
101-
]
100+
]

‎test/syntax/json/indexed-properties.json

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
"type": "operation",
2525
"getter": true,
2626
"setter": false,
27-
"creator": false,
2827
"deleter": false,
2928
"static": false,
3029
"stringifier": false,
@@ -57,7 +56,6 @@
5756
"type": "operation",
5857
"getter": false,
5958
"setter": true,
60-
"creator": false,
6159
"deleter": false,
6260
"static": false,
6361
"stringifier": false,
@@ -103,7 +101,6 @@
103101
"type": "operation",
104102
"getter": false,
105103
"setter": false,
106-
"creator": false,
107104
"deleter": true,
108105
"static": false,
109106
"stringifier": false,
@@ -136,7 +133,6 @@
136133
"type": "operation",
137134
"getter": true,
138135
"setter": false,
139-
"creator": false,
140136
"deleter": false,
141137
"static": false,
142138
"stringifier": false,
@@ -169,7 +165,6 @@
169165
"type": "operation",
170166
"getter": false,
171167
"setter": true,
172-
"creator": true,
173168
"deleter": false,
174169
"static": false,
175170
"stringifier": false,
@@ -215,7 +210,6 @@
215210
"type": "operation",
216211
"getter": false,
217212
"setter": false,
218-
"creator": false,
219213
"deleter": true,
220214
"static": false,
221215
"stringifier": false,
@@ -248,4 +242,4 @@
248242
"inheritance": null,
249243
"extAttrs": []
250244
}
251-
]
245+
]

‎test/syntax/json/iterator.json

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
"type": "operation",
99
"getter": false,
1010
"setter": false,
11-
"creator": false,
1211
"deleter": false,
1312
"static": false,
1413
"stringifier": false,
@@ -57,7 +56,6 @@
5756
"type": "iterator",
5857
"getter": false,
5958
"setter": false,
60-
"creator": false,
6159
"deleter": false,
6260
"static": false,
6361
"stringifier": false,
@@ -108,7 +106,6 @@
108106
"type": "operation",
109107
"getter": false,
110108
"setter": false,
111-
"creator": false,
112109
"deleter": false,
113110
"static": false,
114111
"stringifier": false,
@@ -157,7 +154,6 @@
157154
"type": "iterator",
158155
"getter": false,
159156
"setter": false,
160-
"creator": false,
161157
"deleter": false,
162158
"static": false,
163159
"stringifier": false,
@@ -234,7 +230,6 @@
234230
"type": "iterator",
235231
"getter": false,
236232
"setter": false,
237-
"creator": false,
238233
"deleter": false,
239234
"static": false,
240235
"stringifier": false,
@@ -261,7 +256,6 @@
261256
"type": "iterator",
262257
"getter": false,
263258
"setter": false,
264-
"creator": false,
265259
"deleter": false,
266260
"static": false,
267261
"stringifier": false,
@@ -279,4 +273,4 @@
279273
"inheritance": null,
280274
"extAttrs": []
281275
}
282-
]
276+
]

0 commit comments

Comments
 (0)