doAdd now call canAddValue

Author: steevanb

changelog.md

@@ -1,5 +1,7 @@
 ### master
 
+- Fix `AbstractCollection::doAdd()` who was not calling `canAddValue()`
+
 ### [5.0.0](../../compare/4.0.0...5.0.0) - 2023-03-14
 
 - [BC Break] Rename repository, namespace and everything else from `TypedArray` to `Collection` 

src/AbstractCollection.php

@@ -172,7 +172,9 @@ protected function doAdd(mixed $value): static
     {
         $this->assertIsNotReadOnly();
 
-        $this->values[] = $value;
+        if ($this->canAddValue($value)) {
+            $this->values[] = $value;
+        }
 
         return $this;
     }

tests/Unit/AbstractCollection/ValudAlreadyExistTest.php renamed to tests/Unit/AbstractCollection/ValudAlreadyExistsTest.php

@@ -10,9 +10,9 @@
     ValueAlreadyExistsModeEnum
 };
 
-final class ValudAlreadyExistTest extends TestCase
+final class ValudAlreadyExistsTest extends TestCase
 {
-    public function testValueAlreadyExistsModeAdd(): void
+    public function testDefault(): void
     {
         $collection = new Collection([10, 11, 11, 13]);
 
@@ -23,7 +23,7 @@ public function testValueAlreadyExistsModeAdd(): void
         static::assertSame(13, $collection->callDoGet(3));
     }
 
-    public function testValueAlreadyExistsModeDoNotAdd(): void
+    public function testDoNotAdd(): void
     {
         $collection = new Collection([10, 11, 11, 13], ValueAlreadyExistsModeEnum::DO_NOT_ADD);
 
@@ -33,7 +33,22 @@ public function testValueAlreadyExistsModeDoNotAdd(): void
         static::assertSame(13, $collection->callDoGet(3));
     }
 
-    public function testValueAlreadyExistsModeException(): void
+    public function testDoNotAdd2(): void
+    {
+        $collection = new Collection([], ValueAlreadyExistsModeEnum::DO_NOT_ADD);
+        $collection
+            ->callDoAdd(10)
+            ->callDoAdd(11)
+            ->callDoAdd(11)
+            ->callDoAdd(13);
+
+        static::assertCount(3, $collection);
+        static::assertSame(10, $collection->callDoGet(0));
+        static::assertSame(11, $collection->callDoGet(1));
+        static::assertSame(13, $collection->callDoGet(2));
+    }
+
+    public function testException(): void
     {
         static::expectException(ValueAlreadyExistsException::class);
         new Collection([10, 11, 11, 13], ValueAlreadyExistsModeEnum::EXCEPTION);