fix: remove wrong prealloc of nodeAddresses slice (#93)

* fix: remove wrong prealloc of nodeAddresses slice

Signed-off-by: Niclas Schad <[email protected]>

* add Details(true) to GetServer

Signed-off-by: Niclas Schad <[email protected]>

* add Details(true) to ListServer

Signed-off-by: Niclas Schad <[email protected]>

---------

Signed-off-by: Niclas Schad <[email protected]>

Author: nschad

pkg/ccm/instances.go

@@ -101,9 +101,12 @@ func (i *Instances) InstanceMetadata(ctx context.Context, node *corev1.Node) (*c
 		return nil, fmt.Errorf("failed to get instance: %w", err)
 	}
 
-	addresses := make([]corev1.NodeAddress, 0, len(server.GetNics()))
-	for _, v := range server.GetNics() {
-		if ipv4, ok := v.GetIpv4Ok(); ok {
+	var addresses []corev1.NodeAddress
+	if len(server.GetNics()) == 0 {
+		return nil, fmt.Errorf("server has no network interfaces")
+	}
+	for _, nic := range server.GetNics() {
+		if ipv4, ok := nic.GetIpv4Ok(); ok {
 			addToNodeAddresses(&addresses,
 				corev1.NodeAddress{
 					Address: ipv4,
@@ -112,15 +115,15 @@ func (i *Instances) InstanceMetadata(ctx context.Context, node *corev1.Node) (*c
 		}
 
 		// TODO: where to find IPv6SupportDisabled
-		if ipv6, ok := v.GetIpv6Ok(); ok {
+		if ipv6, ok := nic.GetIpv6Ok(); ok {
 			addToNodeAddresses(&addresses,
 				corev1.NodeAddress{
 					Address: ipv6,
 					Type:    corev1.NodeInternalIP,
 				})
 		}
 
-		if publicIP, ok := v.GetPublicIpOk(); ok {
+		if publicIP, ok := nic.GetPublicIpOk(); ok {
 			addToNodeAddresses(&addresses,
 				corev1.NodeAddress{
 					Address: publicIP,

pkg/stackit/server.go

@@ -7,7 +7,7 @@ import (
 )
 
 func (cl nodeClient) GetServer(ctx context.Context, projectID, region, serverID string) (*iaas.Server, error) {
-	server, err := cl.client.GetServerExecute(ctx, projectID, region, serverID)
+	server, err := cl.client.GetServer(ctx, projectID, region, serverID).Details(true).Execute()
 	if isOpenAPINotFound(err) {
 		return server, ErrorNotFound
 	}
@@ -31,7 +31,7 @@ func (cl nodeClient) UpdateServer(ctx context.Context, projectID, region, server
 }
 
 func (cl nodeClient) ListServers(ctx context.Context, projectID, region string) (*[]iaas.Server, error) {
-	resp, err := cl.client.ListServersExecute(ctx, projectID, region)
+	resp, err := cl.client.ListServers(ctx, projectID, region).Details(true).Execute()
 	if err != nil {
 		return nil, err
 	}