Docs theme 2023.1 #1981
Docs theme 2023.1 #1981
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the documentation theme to sphinx-immaterial, which is a nice visual upgrade. The changes are mostly configuration for the new theme. I have two suggestions for improvement: first, to pin the new sphinx-immaterial dependency in requirements.txt for more stable and reproducible builds. Second, I've suggested a change to the theme's color palette toggle configuration in conf.py to make it more intuitive for users switching between light and dark modes.
| sphinx>=4.2.0 # BSD | ||
| sphinxcontrib-svg2pdfconverter>=0.1.0 # BSD | ||
| Sphinx-Substitution-Extensions # Apache-2.0 | ||
| sphinx-immaterial # MIT |
There was a problem hiding this comment.
To ensure reproducible documentation builds and prevent unexpected breakages from future updates, it's a good practice to pin the version of this dependency. You could specify a minimum version or an exact version. For example, sphinx-immaterial>=0.11.1.
sphinx-immaterial>=0.11.1 # MIT
|
Not worth the time to fix issues right now |
No description provided.