Skip to content

Commit 871dd6c

Browse files
seunghun1eeAlex-Welsh
authored andcommitted
Drop support for building MariaDB clustercheck
MariaDB clustercheck script has not been maintained and it will not work with MariaDB 11.4 (the next LTS version). This is because clustercheck.sh uses ``mysql*`` commands but from MariaDB 11.4, those commands are not supported. The health check of MariaDB server containers will be done by new script which comes with change [1]. Without MariaDB clustercheck, MariaDB server becomes only container image in the family, so mariadb-base and mariadb-server dockerfiles are merged. To avoid breaking changes, the name 'mariadb-server' is retained. Follow-up to rename references in Kolla and K-A from 'mariadb-server' to 'mariadb' would be nice. [1] https://review.opendev.org/c/openstack/kolla/+/962657 Change-Id: I01278f76ee82b018a854b5862f3caaa8c78a9a30 Signed-off-by: Seunghun Lee <[email protected]>
1 parent 2c046ae commit 871dd6c

File tree

15 files changed

+21
-101
lines changed

15 files changed

+21
-101
lines changed

docker/mariadb/mariadb-server/Dockerfile.j2 renamed to docker/mariadb-server/Dockerfile.j2

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM {{ namespace }}/{{ image_prefix }}mariadb-base:{{ tag }}
1+
FROM {{ namespace }}/{{ image_prefix }}base:{{ tag }}
22
{% block labels %}
33
LABEL maintainer="{{ maintainer }}" name="{{ image_name }}" build-date="{{ build_date }}"
44
{% endblock %}
@@ -18,6 +18,7 @@ LABEL maintainer="{{ maintainer }}" name="{{ image_name }}" build-date="{{ build
1818

1919
{% set mariadb_packages = [
2020
'expect',
21+
'mariadb',
2122
'mariadb-backup',
2223
'mariadb-server',
2324
'mariadb-server-galera',
@@ -34,12 +35,19 @@ RUN ln -s /usr/lib64/galera-4 /usr/lib64/galera
3435
{% set mariadb_packages = [
3536
'expect',
3637
'mariadb-backup',
38+
'mariadb-client',
3739
'mariadb-server'
3840
] %}
3941
{% endif %}
4042

4143
{{ macros.install_packages(mariadb_packages | customizable("packages")) }}
4244

45+
{% block mariadb_healthcheck %}
46+
ENV MARIADB_VERSION=10.11
47+
ADD plugins-archive /
48+
RUN install -m 755 /plugins/mariadb-server-plugin-mariadb-docker-archive*/$MARIADB_VERSION/healthcheck.sh /usr/bin/healthcheck.sh
49+
{% endblock %}
50+
4351
COPY mariadb_sudoers /etc/sudoers.d/kolla_mariadb_sudoers
4452
COPY extend_start.sh /usr/local/bin/kolla_extend_start
4553
COPY security_reset.expect /usr/local/bin/kolla_security_reset
File renamed without changes.

docker/mariadb/mariadb-base/Dockerfile.j2

Lines changed: 0 additions & 44 deletions
This file was deleted.

docker/mariadb/mariadb-clustercheck/Dockerfile.j2

Lines changed: 0 additions & 19 deletions
This file was deleted.

docker/mariadb/mariadb-clustercheck/extend_start.sh

Lines changed: 0 additions & 11 deletions
This file was deleted.

0 commit comments

Comments
 (0)