Skip to content

Conversation

@bertiethorpe
Copy link
Member

Addresses #680 (comment)

This PR breaks the existing dependency for openondemand app installs to require a cluster to be deployed in the environment used for image builds.

  • openondemand_*_partition is overridden for builder vars so that ood app install always included in image builds
  • In this case the named partitions don't actually exist and so vars are simply truthy
  • In the common environment, logic handles cases where openhpc_partitions is defined and populated, defined and empty and undefined

@bertiethorpe bertiethorpe marked this pull request as ready for review November 7, 2025 17:32
@bertiethorpe bertiethorpe requested a review from a team as a code owner November 7, 2025 17:32
@sjpb sjpb self-requested a review November 12, 2025 10:30
Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but needs CI running

@sjpb
Copy link
Collaborator

sjpb commented Nov 13, 2025

@sjpb sjpb self-requested a review November 13, 2025 10:07
Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There also appears to be a later image build run at e306e16 which failed: 601

Is there a reason we don't need that?

@bertiethorpe
Copy link
Member Author

There also appears to be a later image build run at e306e16 which failed: 601

Is there a reason we don't need that?

That failed build was for SMS, testing purposes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants