use fcqn following the ansible lint guidelines

Author: Tcharl

handlers/main.yml

@@ -1,21 +1,21 @@
 ---
 
 - name: reload systemd
-  systemd:
+  ansible.builtin.systemd:
     daemon_reload: true
   become: true
 
 # The socket units cannot be stopped or started if libvirt is running.
 - name: stop libvirt
-  service:
+  ansible.builtin.service:
     name: libvirtd
     state: stopped
   become: true
   listen:
     - restart libvirt
 
 - name: start libvirtd sockets
-  service:
+  ansible.builtin.service:
     name: "{{ item.service }}"
     state: "{{ item.enabled | bool | ternary('started', 'stopped') }}"
   become: true
@@ -26,11 +26,11 @@
     - restart libvirt
 
 - name: start libvirt
-  service:
+  ansible.builtin.service:
     name: libvirtd
     state: started
   become: true
 
 - name: reload libvirt qemu apparmor profile template
-  command: apparmor_parser -r /etc/apparmor.d/libvirt/TEMPLATE.qemu
+  ansible.builtin.command: apparmor_parser -r /etc/apparmor.d/libvirt/TEMPLATE.qemu
   become: true

molecule/default/converge.yml

@@ -30,7 +30,7 @@
     - role: tcharl.ansible_role_libvirt_host
   tasks:
     - name: "Post converge - Install vagrant"
-      package:
+      ansible.builtin.package:
         name:
          - qemu
          - libvirt
@@ -46,27 +46,27 @@
       become: true
 
     - name: Start libvirtd
-      service:
+      ansible.builtin.service:
         name: libvirtd
         state: started
       become: true
 
     - name: Copy vagrant file
-      copy:
+      ansible.builtin.copy:
         src: Vagrantfile
         dest: /home/vagrant/Vagrantfile
         owner: vagrant
         group: vagrant
         mode: '0644'
 
     - name: Execute Vagrant as daemon
-      command:
+      ansible.builtin.command:
         cmd: "daemonize -e /home/vagrant/myvmerr.log -o /home/vagrant/myvm.log -c /home/vagrant -E VAGRANT_LOG=info /usr/bin/vagrant up --provider=libvirt"
         chdir: /home/vagrant
         creates: /home/vagrant/myvm.log
 
     - name: Wait until the string "auth" is in the vagrant log
-      wait_for:
+      ansible.builtin.wait_for:
         path: /home/vagrant/myvmerr.log
         search_regex: SSH\sis\sready
         timeout: 1800

molecule/default/molecule.yml

@@ -12,7 +12,7 @@ lint: |
   set -e
   yamllint .
   flake8
-  ANSIBLE_ROLES_PATH=${MOLECULE_PROJECT_DIRECTORY}/../community ANSIBLE_COLLECTIONS_PATH=${MOLECULE_PROJECT_DIRECTORY}/../community-collections ansible-lint
+  ANSIBLE_ROLES_PATH=${MOLECULE_PROJECT_DIRECTORY}/..:${MOLECULE_PROJECT_DIRECTORY}/../community:${ANSIBLE_ROLES_PATH} ANSIBLE_COLLECTIONS_PATH=${MOLECULE_PROJECT_DIRECTORY}/../community-collections:${ANSIBLE_COLLECTIONS_PATH} ansible-lint
 platforms:
   - name: Fedora-Molecule-libvirt-host
     box: fedora/35-cloud-base

molecule/default/tests/__pycache__/conftest.cpython-39-pytest-7.1.2.pyc

@@ -26,7 +26,7 @@
     - role: tcharl.ansible_role_libvirt_host
   tasks:
     - name: "Post converge - Install vagrant"
-      package:
+      ansible.builtin.package:
         name:
          - qemu
          - libvirt
@@ -42,27 +42,27 @@
       become: true
 
     - name: Start libvirtd
-      service:
+      ansible.builtin.service:
         name: libvirtd
         state: started
       become: true
 
     - name: Copy vagrant file
-      copy:
+      ansible.builtin.copy:
         src: Vagrantfile
         dest: /home/vagrant/Vagrantfile
         owner: vagrant
         group: vagrant
         mode: '0644'
 
     - name: Execute Vagrant as daemon
-      command:
+      ansible.builtin.command:
         cmd: "daemonize -e /home/vagrant/myvmerr.log -o /home/vagrant/myvm.log -c /home/vagrant -E VAGRANT_LOG=info /usr/bin/vagrant up --provider=libvirt"
         chdir: /home/vagrant
         creates: /home/vagrant/myvm.log
 
     - name: Wait until the string "auth" is in the vagrant log
-      wait_for:
+      ansible.builtin.wait_for:
         path: /home/vagrant/myvmerr.log
         search_regex: SSH\sis\sready
         timeout: 1800

molecule/default/tests/__pycache__/test_default.cpython-39-pytest-7.1.2.pyc

@@ -1,6 +1,6 @@
 ---
 - name: Ensure client configuration files exist
-  template:
+  ansible.builtin.template:
     src: "{{ item.src }}"
     dest: "{{ item.dest }}"
     owner: "{{ item.owner }}"

molecule/kvm/converge.yml

@@ -1,8 +1,8 @@
 <network {% if item.ipv6 is defined %}ipv6='yes'{% endif %} connections='1'>
   <name>{{ item.name }}</name>
-  <forward mode='{{ item.mode }}'/>
+  {% if item.mode is defined %}<forward mode='{{ item.mode }}'/>{% endif %}
   <bridge name='{{ item.bridge }}'{% if item.zone is defined %} zone='{{ item.zone }}'{% endif %}/>
-{% if item.mode == 'route' or item.mode == 'nat' %}
+{% if item.mode is not defined or item.mode in ['route', 'nat'] %}
   <domain name='{{ item.domain|default(item.name) }}'/>
   <ip address='{{ item.ip }}' netmask='{{ item.netmask }}'>
   {% if item.dhcp_start is defined and item.dhcp_end is defined %}

tasks/client-config.yml

@@ -23,6 +23,7 @@ libvirt_host_packages_efi_by_version:
     - qemu-kvm-ev # Need smm support for secure boot
   8:
     - edk2-ovmf
+  35: [] # fedora
 
 libvirt_host_packages_efi: >-
   {{ libvirt_host_packages_efi_by_version[ansible_facts.distribution_major_version | int] }}
@@ -53,6 +54,7 @@ libvirt_host_custom_yum_repos_efi_by_version:
       baseurl: http://mirror.centos.org/$contentdir/$releasever/virt/$basearch/kvm-common/
       gpgcheck: yes
   8: []
+  35: [] # Fedora :-)
 
 libvirt_host_custom_yum_repos: >-
   {{ libvirt_host_custom_yum_repos_efi_by_version[ansible_facts.distribution_major_version | int] }}