Product image selection: only override version for PR builds (#812)

* Product image selection: only override version for PR builds

Also adds logging because this was pretty confusing to me.

* Changelog

Author: nightkr

crates/stackable-operator/CHANGELOG.md

@@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
 
 ## [Unreleased]
 
+### Fixed
+
+- Product image selection pull request version override now only applies to pull requests ([#812]).
+
+[#812]: https://github.com/stackabletech/operator-rs/pull/812
+
 ## [0.69.3] - 2024-06-12
 
 ### Fixed

crates/stackable-operator/src/commons/product_image_selection.rs

@@ -130,8 +130,14 @@ impl ProductImage {
                 let stackable_version = match &image_selection.stackable_version {
                     Some(stackable_version) => stackable_version,
                     None => {
-                        if operator_version.starts_with("0.0.0-") {
-                            "0.0.0-dev"
+                        if operator_version.starts_with("0.0.0-pr") {
+                            let override_version = "0.0.0-dev";
+                            tracing::warn!(
+                                operator_version,
+                                override_version,
+                                "operator is built by pull request, using dev build of product image"
+                            );
+                            override_version
                         } else {
                             operator_version
                         }