Skip to content

Commit bdf0b19

Browse files
xeniapeadwk67razvan
authored
fix: rename hbase-site.xml keys for restserver advertisement (#716)
* fix: rename hbase-site.xml keys for restserver advertisement * add changelog entry * Update rust/operator-binary/src/hbase_controller.rs Co-authored-by: Andrew Kenworthy <[email protected]> * adjust changelog entry * Update CHANGELOG.md Co-authored-by: Razvan-Daniel Mihai <[email protected]> --------- Co-authored-by: Andrew Kenworthy <[email protected]> Co-authored-by: Razvan-Daniel Mihai <[email protected]>
1 parent 2ac59d1 commit bdf0b19

File tree

2 files changed

+8
-11
lines changed

2 files changed

+8
-11
lines changed

CHANGELOG.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,12 @@
44

55
### Added
66

7-
- Add `hbase.rest.hostname`, `hbase.rest.port`, and `hbase.rest.info.port` properties to the restserver `hbase-site.xml` ([#708]).
7+
- Add custom `hbase.rest.endpoint` property to the restserver `hbase-site.xml` ([#708], [#716]).
8+
- The custom `hbase.rest.hostname` and native `hbase.rest.port` properties cannot be used for
9+
discovery advertisement, as these should remain stable regardless of listener class used to expose the REST service.
810

911
[#708]: https://github.com/stackabletech/hbase-operator/pull/708
12+
[#716]: https://github.com/stackabletech/hbase-operator/pull/716
1013

1114
## [25.11.0] - 2025-11-07
1215

rust/operator-binary/src/hbase_controller.rs

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -593,16 +593,10 @@ fn build_rolegroup_config_map(
593593
}
594594
HbaseRole::RestServer => {
595595
hbase_site_config.insert(
596-
"hbase.rest.hostname".to_string(),
597-
"${env:HBASE_SERVICE_HOST}".to_string(),
598-
);
599-
hbase_site_config.insert(
600-
"hbase.rest.port".to_string(),
601-
"${env:HBASE_SERVICE_PORT}".to_string(),
602-
);
603-
hbase_site_config.insert(
604-
"hbase.rest.info.port".to_string(),
605-
"${env:HBASE_INFO_PORT}".to_string(),
596+
// N.B. a custom tag, so as not to interfere with HBase internals.
597+
// The other roles use a patch to correctly resolve host/port.
598+
"hbase.rest.endpoint".to_string(),
599+
"${env:HBASE_SERVICE_HOST}:${env:HBASE_SERVICE_PORT}".to_string(),
606600
);
607601
}
608602
};

0 commit comments

Comments
 (0)