Support ObjectMap for std::stack, std::queue, std::priority_queue #1488

leekillough · 2025-11-20T20:12:46Z

Support ObjectMap for std::stack, std::queue, std::priority_queue

github-actions · 2025-11-20T20:13:15Z

CLANG-FORMAT TEST - PASSED

sst-autotester · 2025-11-20T20:20:20Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

github-actions · 2025-11-29T20:18:17Z

CLANG-FORMAT TEST - PASSED

sst-autotester · 2025-11-29T20:36:21Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

github-actions · 2025-11-30T06:19:41Z

CLANG-FORMAT TEST - PASSED

sst-autotester · 2025-11-30T06:49:41Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

src/sst/core/serialization/impl/serialize_adapter.h

github-actions · 2025-12-01T21:01:42Z

CLANG-FORMAT TEST - PASSED

sst-autotester · 2025-12-01T21:06:57Z

Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; this inspection will remain valid until a new commit to source branch is performed.

leekillough · 2025-12-01T21:09:20Z

src/sst/core/serialization/impl/serialize_adapter.h

+        case serializer::MAP:
+            ser.mapper().map_hierarchy_start(ser.getMapName(), new ObjectMapContainer<T>(&v));
+            SST_SER_NAME(static_cast<S&>(v).c, "container",
+                options | SerOption::map_read_only); // serialize the underlying container


It's read-only now. Question: Do we really need to pass other options down, or can we just ignore options and pass SerOption::map_read_only? (In that case, we probably don't need to pass options in the SST_SER() call below either, and we can say UNUSED(options).)

For now, I believe read-only only affects fundamentals because it is not applied to members of a class. We'll need to figure out how we want this to apply to data members. We may need to track it as part of the path. I could see accessing an object through different paths where on path is read-only and the other isn't. It's an interesting problem.

Yes, but my question was mainly about other options when serializing, say std::priority_queue. Are there any serialization options when serializing std::priority_queue which need to be passed when serializing the underlying container, or can we just ignore all serialization options passed when serializing std::priority_queue?

I add read-only for std::priority_queue now, but I pass the adapter serialization options as-is to the serialization of the underlying container.

sst-autotester · 2025-12-01T21:10:09Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements

Build Num: 2374
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MR-2

Build Num: 2328
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MT-2

Build Num: 2327
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-core_Make-Dist

Build Num: 972
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-15-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements

Build Num: 878
Status: STARTED

Using Repos:

Repo: CORE (leekillough/sst-core)

Repo: SQE (sstsimulator/sst-sqe)

Repo: ELEMENTS (sstsimulator/sst-elements)

Repo: MACRO (sstsimulator/sst-macro)

Pull Request Author: leekillough

sst-autotester · 2025-12-01T22:46:28Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements

Build Num: 2374
Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MR-2

Build Num: 2328
Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MT-2

Build Num: 2327
Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-core_Make-Dist

Build Num: 972
Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-15-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements

Build Num: 878
Status: PASSED

sst-autotester · 2025-12-01T22:46:47Z

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
THE LAST COMMIT TO THIS PULL REQUEST HAS BEEN REVIEWED, BUT NOT ACCEPTED OR REQUIRES CHANGES!

sst-autotester · 2025-12-01T22:46:53Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

github-actions · 2025-12-02T02:29:18Z

CLANG-FORMAT TEST - PASSED

github-actions · 2025-12-02T02:29:25Z

CLANG-FORMAT TEST - PASSED

sst-autotester · 2025-12-02T02:49:03Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

github-actions · 2025-12-02T03:37:04Z

CLANG-FORMAT TEST - PASSED

github-actions bot added AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) AT: CLANG-FORMAT PASS and removed AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) labels Nov 20, 2025

leekillough force-pushed the objectmap_adapter branch from e6dbf3b to f6dea0a Compare November 29, 2025 20:17

github-actions bot added AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) and removed AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) labels Nov 29, 2025

leekillough force-pushed the objectmap_adapter branch from f6dea0a to b4172f2 Compare November 30, 2025 06:19

github-actions bot added AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) and removed AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) labels Nov 30, 2025

feldergast reviewed Dec 1, 2025

View reviewed changes

src/sst/core/serialization/impl/serialize_adapter.h Outdated Show resolved Hide resolved

Add missing #include <memory>

21f5394

feldergast added the AT: PRE-TEST INSPECTED label Dec 1, 2025

Support ObjectMap for std::stack, std::queue, std::priority_queue

6d9527e

leekillough force-pushed the objectmap_adapter branch from b4172f2 to 6d9527e Compare December 1, 2025 21:01

github-actions bot added AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) and removed AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) labels Dec 1, 2025

sst-autotester removed the AT: PRE-TEST INSPECTED label Dec 1, 2025

leekillough commented Dec 1, 2025

View reviewed changes

leekillough added 2 commits December 1, 2025 20:28

Set read-only mode only for std::priority_queue

7a954fb

Merge remote-tracking branch 'sstcore/devel' into objectmap_adapter

6dc1f9f

github-actions bot added AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) and removed AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) labels Dec 2, 2025

Merge branch 'include_memory' into objectmap_adapter

c1dbb2b

github-actions bot added AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) and removed AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) labels Dec 2, 2025

leekillough requested a review from feldergast December 2, 2025 07:20

Support ObjectMap for std::stack, std::queue, std::priority_queue #1488

Are you sure you want to change the base?

Support ObjectMap for std::stack, std::queue, std::priority_queue #1488

Conversation

leekillough commented Nov 20, 2025

Uh oh!

github-actions bot commented Nov 20, 2025

Uh oh!

sst-autotester commented Nov 20, 2025

Uh oh!

github-actions bot commented Nov 29, 2025

Uh oh!

sst-autotester commented Nov 29, 2025

Uh oh!

github-actions bot commented Nov 30, 2025

Uh oh!

sst-autotester commented Nov 30, 2025

Uh oh!

Uh oh!

github-actions bot commented Dec 1, 2025

Uh oh!

sst-autotester commented Dec 1, 2025

Uh oh!

leekillough Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

feldergast Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

leekillough Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

leekillough Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

sst-autotester commented Dec 1, 2025

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MR-2

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MT-2

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-core_Make-Dist

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-15-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements

Using Repos:

Uh oh!

sst-autotester commented Dec 1, 2025

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MR-2

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MT-2

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-core_Make-Dist

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-15-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements

Uh oh!

sst-autotester commented Dec 1, 2025

Uh oh!

sst-autotester commented Dec 1, 2025

Uh oh!

github-actions bot commented Dec 2, 2025

Uh oh!

github-actions bot commented Dec 2, 2025

Uh oh!

sst-autotester commented Dec 2, 2025

Uh oh!

github-actions bot commented Dec 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants