Skip to content

Reenable serialization of std::shared_ptr, making std::weak_ptr array serialization contingent on SST_SERIALIZE_WEAK_PTR_ARRAY macro #1485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 29, 2025
Merged

Reenable serialization of std::shared_ptr, making std::weak_ptr array serialization contingent on SST_SERIALIZE_WEAK_PTR_ARRAY macro #1485

merged 2 commits into from
Nov 29, 2025
+86 −40

Conversation

@leekillough
Copy link
Contributor

@leekillough leekillough commented Nov 17, 2025 •
edited
Loading

Reenable serialization of std::shared_ptr, making std::weak_ptr array serialization contingent on a SST_SERIALIZE_WEAK_PTR_ARRAY macro.

Many older versions of C++ libraries do not support std::weak_ptr correctly, especially std::weak_ptr with arrays. This is probably due to much less knowledge and testing of std::weak_ptr, as well as an oversight in the C++17 standard.

In this PR we enable serialization of std::weak_ptr arrays with:

#if defined(_LIBCPP_VERSION) && _LIBCPP_VERSION < 150000
#define SST_SERIALIZE_WEAK_PTR_ARRAY 0
#else
#define SST_SERIALIZE_WEAK_PTR_ARRAY 1
#endif

This libc++ bug fix was released in version 15.

This libstdc++ bug has a workaround (see the comments in the code changes).

I do not have a MacOS 14 machine to test with.

@github-actions github-actions bot added AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) AT: CLANG-FORMAT PASS and removed AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) labels Nov 17, 2025
@github-actions
Copy link

github-actions bot commented Nov 17, 2025

CLANG-FORMAT TEST - PASSED

@sst-autotester
Copy link
Contributor

sst-autotester commented Nov 17, 2025

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

@leekillough

This comment was marked as resolved.

Sign in to view
@leekillough leekillough marked this pull request as draft November 17, 2025 21:47
@leekillough
Reenable serialization of std::shared_ptr, making std::weak_ptr array…
3306d75 
… serialization dependent on SST_SERIALIZE_WEAK_PTR_ARRAY
@leekillough leekillough force-pushed the reenable_shared_ptr_serialization branch from 43861c0 to 3306d75 Compare November 17, 2025 22:26
@github-actions github-actions bot added AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) and removed AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) labels Nov 17, 2025
@github-actions
Copy link

github-actions bot commented Nov 17, 2025

CLANG-FORMAT TEST - PASSED

@leekillough leekillough changed the title Reenable serialization of std::shared_ptr, making std::weak_ptr serialization dependent on SST_SERIALIZE_WEAK_PTR macro Reenable serialization of std::shared_ptr, making std::weak_ptr array serialization dependent on SST_SERIALIZE_WEAK_PTR macro Nov 17, 2025
@leekillough leekillough changed the title Reenable serialization of std::shared_ptr, making std::weak_ptr array serialization dependent on SST_SERIALIZE_WEAK_PTR macro Reenable serialization of std::shared_ptr, making std::weak_ptr array serialization dependent on SST_SERIALIZE_WEAK_PTR_ARRAY macro Nov 17, 2025
@leekillough leekillough changed the title Reenable serialization of std::shared_ptr, making std::weak_ptr array serialization dependent on SST_SERIALIZE_WEAK_PTR_ARRAY macro Reenable serialization of std::shared_ptr, making std::weak_ptr array serialization contingent on SST_SERIALIZE_WEAK_PTR_ARRAY macro Nov 17, 2025
@leekillough leekillough marked this pull request as ready for review November 17, 2025 22:36
@github-actions github-actions bot added AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) and removed AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) labels Nov 18, 2025
@github-actions
Copy link

github-actions bot commented Nov 18, 2025

CLANG-FORMAT TEST - PASSED

@sst-autotester
Copy link
Contributor

sst-autotester commented Nov 18, 2025

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

@sst-autotester
Copy link
Contributor

sst-autotester commented Nov 25, 2025

Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; this inspection will remain valid until a new commit to source branch is performed.

@sst-autotester
Copy link
Contributor

sst-autotester commented Nov 25, 2025

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements

  • Build Num: 2366
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MR-2

  • Build Num: 2320
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MT-2

  • Build Num: 2319
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-core_Make-Dist

  • Build Num: 965
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-15-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements

  • Build Num: 870
  • Status: STARTED

Using Repos:

Repo: CORE (leekillough/sst-core)
  • Branch: reenable_shared_ptr_serialization
  • SHA: 196ed76
  • Mode: TEST_REPO
Repo: SQE (sstsimulator/sst-sqe)
  • Branch: devel
  • SHA: 1e54a5e211d27c88697dab709c0b1d3293cd4a1e
  • Mode: SUPPORT_REPO
Repo: ELEMENTS (sstsimulator/sst-elements)
  • Branch: devel
  • SHA: a18a0bc3b03ed4464a0b8af9dbb9ae5562093f94
  • Mode: SUPPORT_REPO
Repo: MACRO (sstsimulator/sst-macro)
  • Branch: devel
  • SHA: 489f035111339bbd94e9db661a68c1b2cd7faf77
  • Mode: SUPPORT_REPO

Pull Request Author: leekillough

@sst-autotester
Copy link
Contributor

sst-autotester commented Nov 25, 2025

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements

  • Build Num: 2366
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MR-2

  • Build Num: 2320
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-elements_MT-2

  • Build Num: 2319
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.9_sst-core_Make-Dist

  • Build Num: 965
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-15-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements

  • Build Num: 870
  • Status: PASSED

@sst-autotester
Copy link
Contributor

sst-autotester commented Nov 25, 2025

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ feldergast ]!

@sst-autotester
Copy link
Contributor

sst-autotester commented Nov 25, 2025

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

1 similar comment
@sst-autotester
Copy link
Contributor

sst-autotester commented Nov 26, 2025

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

@sst-autotester
Copy link
Contributor

sst-autotester commented Nov 26, 2025

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

19 similar comments
@sst-autotester
Copy link
Contributor

sst-autotester commented Nov 26, 2025

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

@sst-autotester
Copy link
Contributor

sst-autotester commented Nov 26, 2025

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

@sst-autotester
Copy link
Contributor

sst-autotester commented Nov 26, 2025

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

@sst-autotester
Copy link
Contributor

sst-autotester commented Nov 26, 2025

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

@sst-autotester
Copy link
Contributor

sst-autotester commented Nov 27, 2025

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

@sst-autotester
Copy link
Contributor

sst-autotester commented Nov 27, 2025

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

@sst-autotester
Copy link
Contributor

sst-autotester commented Nov 27, 2025

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

@sst-autotester
Copy link
Contributor

sst-autotester commented Nov 27, 2025

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

@sst-autotester
Copy link
Contributor

sst-autotester commented Nov 27, 2025

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

@sst-autotester
Copy link
Contributor

sst-autotester commented Nov 28, 2025

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

@sst-autotester
Copy link
Contributor

sst-autotester commented Nov 28, 2025

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

@sst-autotester
Copy link
Contributor

sst-autotester commented Nov 28, 2025

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

@sst-autotester
Copy link
Contributor

sst-autotester commented Nov 28, 2025

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

@sst-autotester
Copy link
Contributor

sst-autotester commented Nov 28, 2025

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

@sst-autotester
Copy link
Contributor

sst-autotester commented Nov 28, 2025

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

@sst-autotester
Copy link
Contributor

sst-autotester commented Nov 29, 2025

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

@sst-autotester
Copy link
Contributor

sst-autotester commented Nov 29, 2025

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

@sst-autotester
Copy link
Contributor

sst-autotester commented Nov 29, 2025

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

@sst-autotester
Copy link
Contributor

sst-autotester commented Nov 29, 2025

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

@feldergast feldergast merged commit 1d077a7 into sstsimulator:devel Nov 29, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@feldergast feldergast feldergast approved these changes

Assignees

No one assigned

Labels

AT: CLANG-FORMAT PASS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@leekillough @sst-autotester @feldergast