cli: use switch correctly to read bare option

Signed-off-by: Javi Fontan <[email protected]>

Author: jfontan

cmd/gitbase/command/server.go

@@ -372,10 +372,10 @@ func (c *Server) addDirectory(d directory) error {
 	return nil
 }
 
-type bareness int
+type bareOpt int
 
 const (
-	bareAuto bareness = iota
+	bareAuto bareOpt = iota
 	bareOn
 	bareOff
 )
@@ -385,7 +385,7 @@ type directory struct {
 	Format string
 	Bucket int
 	Rooted bool
-	Bare   bareness
+	Bare   bareOpt
 }
 
 var (
@@ -431,18 +431,17 @@ func parseDirectory(dir directory) (directory, error) {
 			dir.Format = val
 
 		case "bare":
-			if val != "true" && val != "false" && val != "auto" {
-				logrus.Errorf("invalid value in bare, it can only "+
-					"be true, false, or auto %v", val)
-				return dir, ErrInvalid
-			}
 			switch val {
 			case "true":
 				dir.Bare = bareOn
 			case "false":
 				dir.Bare = bareOff
 			case "auto":
 				dir.Bare = bareAuto
+			default:
+				logrus.Errorf("invalid value in bare, it can only "+
+					"be true, false, or auto %v", val)
+				return dir, ErrInvalid
 			}
 
 		case "rooted":

cmd/gitbase/command/server_test.go

@@ -182,7 +182,7 @@ func TestDiscoverBare(t *testing.T) {
 
 	tests := []struct {
 		path     string
-		bare     bareness
+		bare     bareOpt
 		expected bool
 		err      bool
 	}{