Skip to content

Invalid MarkupKind in completion item documentation #175

@valentinegb

Description

@valentinegb

Describe the bug

The LSP specification says that MarkupKind should be either "plaintext" or "markdown", however it seems that sqls is sending "", which is invalid.

To Reproduce

Steps to reproduce the behavior:

  1. Open an SQL file
  2. Trigger autocomplete

Expected behavior

sqls is giving CompletionItems with the following:

{
  // ...
  "documentation": { "kind": "", "value": "" },
  // ...
},

It should probably not specify documentation at all in cases like this.

Versions (please complete the following information):

  • OS Version: macOS 15.4 Beta (24E5206s)
  • sqls Version: v0.2.27

Additional context

Example of erroneous response:

[
  {
    "label": "ABORT",
    "kind": 14,
    "detail": "keyword",
    "documentation": { "kind": "", "value": "" },
    "sortText": "9999ABORT"
  },
  {
    "label": "ACTION",
    "kind": 14,
    "detail": "keyword",
    "documentation": { "kind": "", "value": "" },
    "sortText": "9999ACTION"
  },
  {
    "label": "ADD",
    "kind": 14,
    "detail": "keyword",
    "documentation": { "kind": "", "value": "" },
    "sortText": "9999ADD"
  },
  {
    "label": "AFTER",
    "kind": 14,
    "detail": "keyword",
    "documentation": { "kind": "", "value": "" },
    "sortText": "9999AFTER"
  },
  // ...
]

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions