Add @JsonProperty support for enum values

[evser]

Hi, starting from 2.6.0 version enums are showing so weird:
contactType (string, optional) = ['skype', 'email', 'phone']stringEnum:"skype", "email", "phone",

Fix it please.

[dilipkrish]

Not sure what that means. Please take time to report a bug with additional details. Here are the issue submission guidelines

[evser]

Just try to create swagger docs with field of enum type and you will see that strage "stringEnum" with duplicate of enum values.

[dilipkrish]

There are demos and functional tests for enums that seem to suggest otherwise. Could you perhaps create a breaking test?

[evser]

I'll show you:

I have a such DTO:

public class LoginDTO implements Serializable {
    private UserTypeEnum userType;
//other fields, getters/setters
}

UserTypeEnum.java :

public enum UserTypeEnum {
    DRIVER, PASSENGER;
    @JsonCreator
    public static UserTypeEnum fromString(String name) {
        return UserTypeEnum.valueOf(name.toUpperCase());
    }
    @JsonValue
    public String getName() {
        return name().toLowerCase();
    }
}

Actually, JSON annotations here are for lowercase view, but the same bug is without them

The result:

Duplication of enum and weird "stringEnum" string.

This bug is not reproducable for 2.5.0

[evser]

BTW, is there another way of lowercase view of enum?

[dilipkrish]

Couple of things,

• Could you try with 2.6.0 to see if its fixed
• Could you please post the json version of the definition (as its shown in the api docs (/v2/api-docs)) of the LoginDTO

[evser]

Please, read more careful, I wrote that this bug is only for 2.6.0, but not 2.5.0.
As for json version:

{
    "swagger": "2.0",
    "info": 
    {
        "description": "Api Documentation",
        "version": "1.0",
        "title": "Api Documentation",
        "termsOfService": "urn:tos",
        "contact": 
        {

        },

        "license": 
        {
            "name": "Apache 2.0",
            "url": "http://www.apache.org/licenses/LICENSE-2.0"
        }
    },

    "host": "HOST",
    "basePath": "/",
    "tags": 
    [
        {
            "name": "login-controller",
            "description": "Login Controller"
        }
    ],

    "paths": 
    {

        "/login": 
        {
            "post": 
            {
                "tags": 
                [
                    "login-controller"
                ],

                "summary": "User login.",
                "operationId": "loginUsingPOST",
                "consumes": 
                [
                    "application/json"
                ],

                "produces": 
                [
                    "*/*"
                ],

                "parameters": 
                [
                    {
                        "in": "body",
                        "name": "login",
                        "description": "login",
                        "required": true,
                        "schema": 
                        {
                            "$ref": "#/definitions/LoginDTO"
                        }
                    }
                ],

                "responses": 
                {
                    "200": 
                    {
                        "description": "OK",
                        "schema": 
                        {
                            "$ref": "#/definitions/LoginDTO"
                        }
                    },

                    "201": 
                    {
                        "description": "Created"
                    },

                    "401": 
                    {
                        "description": "Unauthorized"
                    },

                    "403": 
                    {
                        "description": "Forbidden"
                    },

                    "404": 
                    {
                        "description": "Not Found"
                    }
                }
            }
        },

    "definitions": 
    {


        "LoginDTO": 
        {
            "type": "object",
            "properties": 
            {
                "deviceToken": 
                {
                    "type": "string"
                },

                "login": 
                {
                    "type": "string"
                },

                "password": 
                {
                    "type": "string"
                },

                "userType": 
                {
                    "type": "string",
                    "enum": 
                    [
                        "driver",
                        "passenger"
                    ]
                }
            }
        }
    }
}

And answer please to the previous comment

[dilipkrish]

Ok I don't see any stringEnum in the json definition. So it must be a bug in swagger-ui

[evser]

Oh, so it's not a fault of springfox?

[evser]

@dilipkrish is there another way of getting enum lowercased using springfox?

[dilipkrish]

You can try setting the allowable values in an @ApiModel annotation for UserTypeEnum

[evser]

It's not really a dynamic option (I mean it's not tolerant to changes). Do you have any plans to add support of @JsonProperty to emuns?
See: FasterXML/jackson-databind#1322
and FasterXML/jackson-databind#677

[Syntobe]

I'd be happy to contribute. Please let me know if i can help.

Best Regards

[dilipkrish]

@Syntobe absolutely! Would be awesome if you can help with this.

[solo-yolo]

@Syntobe @dilipkrish
Hi guys!
Is there any progress regarding support of @JsonProperty for enum values?

[Syntobe]

I'll try to have a look at it next week. I keep you posted =)

…

On Fri, 22 Jun 2018, 09:54 Serhii Solohub, ***@***.***> wrote: @Syntobe <https://github.com/Syntobe> @dilipkrish <https://github.com/dilipkrish> Hi guys! Is there any progress regarding support of @JsonProperty for enum values? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1533 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AZmygGr5j8yUyb7fK_7wIusvGxZTUsehks5t_KKqgaJpZM4Kb6dg> .

[solo-yolo]

Cool! Thanks
We currently using a workaround with param/model plugins but would like to see that feature in nearest release :)

[magicbyte-fe]

@solo-yolo Hi! What kind of workaround?

[solo-yolo]

@doctorstrange85 sorry, but I don't work on that project anymore, and unfortunately can't remember what we did to workaround this issue :(