Skip to content

Commit 924b8a8

Browse files
committed
Restore STCEH Behavior After Previous Commit
1 parent bb3d3df commit 924b8a8

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

spring-kafka/src/main/java/org/springframework/kafka/listener/SeekToCurrentErrorHandler.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -109,10 +109,8 @@ public void setAckAfterHandle(boolean ackAfterHandle) {
109109
public void handle(Exception thrownException, @Nullable List<ConsumerRecord<?, ?>> records,
110110
Consumer<?, ?> consumer, MessageListenerContainer container) {
111111

112-
if (records != null) {
113-
SeekUtils.seekOrRecover(thrownException, records, consumer, container, isCommitRecovered(),
114-
getRecoveryStrategy(records, thrownException), this.logger, getLogLevel());
115-
}
112+
SeekUtils.seekOrRecover(thrownException, records, consumer, container, isCommitRecovered(),
113+
getRecoveryStrategy(records, thrownException), this.logger, getLogLevel());
116114
}
117115

118116
}

spring-kafka/src/main/java/org/springframework/kafka/listener/SeekUtils.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ public static void seekOrRecover(Exception thrownException, List<ConsumerRecord<
185185
* @param level the log level for the thrown exception after handling.
186186
* @since 2.7
187187
*/
188-
public static void seekOrRecover(Exception thrownException, List<ConsumerRecord<?, ?>> records,
188+
public static void seekOrRecover(Exception thrownException, @Nullable List<ConsumerRecord<?, ?>> records,
189189
Consumer<?, ?> consumer, MessageListenerContainer container, boolean commitRecovered,
190190
RecoveryStrategy recovery, LogAccessor logger, Level level) {
191191

@@ -202,7 +202,7 @@ public static void seekOrRecover(Exception thrownException, List<ConsumerRecord<
202202
}
203203
}
204204

205-
if (!doSeeks(records, consumer, thrownException, true, recovery, container, logger)) {
205+
if (records == null || !doSeeks(records, consumer, thrownException, true, recovery, container, logger)) {
206206
throw new KafkaException("Seek to current after exception", level, thrownException);
207207
}
208208
if (commitRecovered) {

0 commit comments

Comments
 (0)