From c67efe429e29a49b848fe202da80185570afe0cc Mon Sep 17 00:00:00 2001 From: Greg Oledzki Date: Tue, 15 Apr 2025 07:47:55 +0200 Subject: [PATCH] refactor: Use Collection#isEmpty() instead of comparing size() Signed-off-by: Greg Oledzki --- src/main/java/org/springframework/hateoas/client/Traverson.java | 2 +- .../mediatype/collectionjson/Jackson2CollectionJsonModule.java | 2 +- .../org/springframework/hateoas/server/core/WebHandler.java | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/java/org/springframework/hateoas/client/Traverson.java b/src/main/java/org/springframework/hateoas/client/Traverson.java index e697695c7..c121a2259 100644 --- a/src/main/java/org/springframework/hateoas/client/Traverson.java +++ b/src/main/java/org/springframework/hateoas/client/Traverson.java @@ -373,7 +373,7 @@ public Link asTemplatedLink() { private Link traverseToLink(boolean expandFinalUrl) { - Assert.isTrue(rels.size() > 0, "At least one rel needs to be provided!"); + Assert.isTrue(!rels.isEmpty(), "At least one rel needs to be provided!"); return Link.of(expandFinalUrl ? traverseToExpandedFinalUrl().getUri().toString() : traverseToFinalUrl().getUri(), rels.get(rels.size() - 1).getRel()); diff --git a/src/main/java/org/springframework/hateoas/mediatype/collectionjson/Jackson2CollectionJsonModule.java b/src/main/java/org/springframework/hateoas/mediatype/collectionjson/Jackson2CollectionJsonModule.java index ef84a00ca..c1031a34b 100644 --- a/src/main/java/org/springframework/hateoas/mediatype/collectionjson/Jackson2CollectionJsonModule.java +++ b/src/main/java/org/springframework/hateoas/mediatype/collectionjson/Jackson2CollectionJsonModule.java @@ -524,7 +524,7 @@ public JsonSerializer getContentSerializer() { @Override @SuppressWarnings("null") public boolean isEmpty(PagedModel value) { - return value.getContent().size() == 0; + return value.getContent().isEmpty(); } /* diff --git a/src/main/java/org/springframework/hateoas/server/core/WebHandler.java b/src/main/java/org/springframework/hateoas/server/core/WebHandler.java index 0925123f3..79f84a079 100644 --- a/src/main/java/org/springframework/hateoas/server/core/WebHandler.java +++ b/src/main/java/org/springframework/hateoas/server/core/WebHandler.java @@ -140,7 +140,7 @@ private static PreparedWebHandler linkTo(Object invoc if (mappingVariable.isCapturing()) { List segments = Arrays.asList(((String) preparedValue).split("/")); - Object value = segments.size() != 0 ? "/" + segment.composite().prepareAndEncode(segments) : ""; + Object value = !segments.isEmpty() ? "/" + segment.composite().prepareAndEncode(segments) : ""; values.put(key, value);