`DefaultApiVersionInserter` encodes already encoded URI

[mengelbrecht]

The DefaultApiVersionInserter encodes an already encoded URI when inserting a path segment version.
This way the URI is double encoded.

The following code:

ApiVersionInserter.usePathSegment(0).insertVersion("1", URI.create("http://localhost/test?foo=%20"))

yields:

http://localhost/1/test?foo=%2520

expected is:

http://localhost/1/test?foo=%20

Attached is a sample project. Executing the included ApiVersionInserterTest reproduces the error.
demo.zip

[rstoyanchev]

Thanks for the report. Indeed the inserter should not re-encode the existing parts of the input URI.

[xyraclius]

Hi @rstoyanchev,

May I work on this issue?

It only requires modifying one line.
If so, I’ll open a PR.

[rstoyanchev]

@xyraclius feel free to submit a PR.