-
Notifications
You must be signed in to change notification settings - Fork 38.7k
Closed as not planned
Closed as not planned
Copy link
Labels
in: webIssues in web modules (web, webmvc, webflux, websocket)Issues in web modules (web, webmvc, webflux, websocket)status: supersededAn issue that has been superseded by anotherAn issue that has been superseded by anothertype: enhancementA general enhancementA general enhancement
Description
Currently the ReactorClientHttpRequestFactory
creates within the default constructor an instance of HttpClient
just with create()
:
public ReactorClientHttpRequestFactory() {
this(defaultInitializer.apply(HttpClient.create()));
}
In this setup the HttpClient
does not apply any system properties for proxy settings (like e.g. https.proxyHost
and https.proxyPort
). Therefore the following code is necessary:
public ReactorClientHttpRequestFactory() {
this(defaultInitializer.apply(HttpClient.create().proxyWithSystemProperties()));
}
As other http client implementations such as Apache HttpClient do apply system properties for proxies in the default setup, this should be the same for the netty http client inside the ReactorClientHttpRequestFactory
.
Metadata
Metadata
Assignees
Labels
in: webIssues in web modules (web, webmvc, webflux, websocket)Issues in web modules (web, webmvc, webflux, websocket)status: supersededAn issue that has been superseded by anotherAn issue that has been superseded by anothertype: enhancementA general enhancementA general enhancement