Skip to content

Reactive infrastructure for annotated method invocation in spring-messaging [SPR-17455] #21987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spring-projects-issues opened this issue Nov 1, 2018 · 0 comments
Closed

Reactive infrastructure for annotated method invocation in spring-messaging [SPR-17455] #21987

spring-projects-issues opened this issue Nov 1, 2018 · 0 comments
Assignees
@rstoyanchev
Labels
in: messaging Issues in messaging modules (jms, messaging) type: task A general task
Milestone
5.2 M1

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Nov 1, 2018 •
edited
Loading

Rossen Stoyanchev opened SPR-17455 and commented

Non-blocking, reactive contract equivalents for:

  • InvocableHandlerMethod and related contracts for resolving method parameters and handling return values.
  • AbstractMethodMessageHandler and sub-classes for message handling through the invocation of annotated handler methods.
  • Implementations of argument resolvers and return value handlers, including use of codecs for payload encoding and decoding.

Affects: 5.1.2

This issue is a sub-task of #21292
@spring-projects-issues spring-projects-issues added in: messaging Issues in messaging modules (jms, messaging) type: task A general task labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 5.2 RC1 milestone Jan 11, 2019
Closed
rstoyanchev added a commit to rstoyanchev/spring-framework that referenced this issue Feb 21, 2019
@rstoyanchev
Reactive InvocableHandlerMethod in spring-messaging
39ce708 
See spring-projectsgh-21987
rstoyanchev added a commit to rstoyanchev/spring-framework that referenced this issue Feb 21, 2019
@rstoyanchev
Encoder/Decoder based payload serialization
7e6c0f3 
See spring-projectsgh-21987
rstoyanchev added a commit to rstoyanchev/spring-framework that referenced this issue Feb 21, 2019
@rstoyanchev
Reactive AbstractMessageMethodHandler
327dbbb 
See spring-projectsgh-21987
rstoyanchev added a commit to rstoyanchev/spring-framework that referenced this issue Feb 21, 2019
@rstoyanchev
Reactive @MessageMapping
35b58b3 
See spring-projectsgh-21987
rstoyanchev added a commit to rstoyanchev/spring-framework that referenced this issue Feb 21, 2019
@rstoyanchev
Resolvers for destination vars and headers
639a22b 
See spring-projectsgh-21987
rstoyanchev added a commit to rstoyanchev/spring-framework that referenced this issue Feb 21, 2019
@rstoyanchev
ReactiveMessageChannel and ReactiveSubscribableChannel
9d7c2e2 
See spring-projectsgh-21987
rstoyanchev added a commit to rstoyanchev/spring-framework that referenced this issue Feb 21, 2019
@rstoyanchev
Payload encoding/decoding and handling refinements
80e4d0d 
See spring-projectsgh-21987
rstoyanchev added a commit to rstoyanchev/spring-framework that referenced this issue Feb 21, 2019
@rstoyanchev
RSocket @MessageMapping handling
483a846 
See spring-projectsgh-21987
rstoyanchev added a commit to rstoyanchev/spring-framework that referenced this issue Feb 21, 2019
@rstoyanchev
RSocketRequester, RSocketStrategies, PayloadUtils
9ceca4f 
See spring-projectsgh-21987
rstoyanchev added a commit to rstoyanchev/spring-framework that referenced this issue Feb 22, 2019
@rstoyanchev
MessagingAcceptor/RSocket refinements + upgrade to 0.11.17
451ae57 
See spring-projectsgh-21987
rstoyanchev added a commit to rstoyanchev/spring-framework that referenced this issue Feb 22, 2019
@rstoyanchev
@MessageExceptionHandler supports error signal
729edb6 
Before this change if a controller method returned a Publisher whose
first signal was an error, the error signal would not be delegated to
a @MessageExceptionHandler method as expected.

To make this work for now we use a package private local copy of the
ChannelSendOperator from spring-web.

See spring-projectsgh-21987
rstoyanchev added a commit to rstoyanchev/spring-framework that referenced this issue Feb 22, 2019
@rstoyanchev
Refactoring in AbstractMethodMessageHandler
cbd5e25 
Delegate the invocation of a HandlerMethod into a separate, delegate,
package private helper class.

See spring-projectsgh-21987
rstoyanchev added a commit to rstoyanchev/spring-framework that referenced this issue Feb 27, 2019
@rstoyanchev
Reactive InvocableHandlerMethod in spring-messaging
2f373fb 
See spring-projectsgh-21987
rstoyanchev added a commit to rstoyanchev/spring-framework that referenced this issue Feb 27, 2019
@rstoyanchev
Encoder/Decoder based payload serialization
0e9d47e 
See spring-projectsgh-21987
rstoyanchev added a commit to rstoyanchev/spring-framework that referenced this issue Feb 27, 2019
@rstoyanchev
Reactive AbstractMessageMethodHandler
ba62a20 
See spring-projectsgh-21987
rstoyanchev added a commit to rstoyanchev/spring-framework that referenced this issue Feb 27, 2019
@rstoyanchev
Reactive @MessageMapping
bdeae3b 
See spring-projectsgh-21987
rstoyanchev added a commit to rstoyanchev/spring-framework that referenced this issue Feb 27, 2019
@rstoyanchev
Resolvers for destination vars and headers
6b523dc 
See spring-projectsgh-21987
rstoyanchev added a commit to rstoyanchev/spring-framework that referenced this issue Feb 27, 2019
@rstoyanchev
ReactiveMessageChannel and ReactiveSubscribableChannel
8fc62cb 
See spring-projectsgh-21987
rstoyanchev added a commit to rstoyanchev/spring-framework that referenced this issue Feb 27, 2019
@rstoyanchev
Payload encoding/decoding and handling refinements
7962a25 
See spring-projectsgh-21987
rstoyanchev added a commit to rstoyanchev/spring-framework that referenced this issue Feb 27, 2019
@rstoyanchev
RSocket @MessageMapping handling
0933e2b 
See spring-projectsgh-21987
rstoyanchev added a commit to rstoyanchev/spring-framework that referenced this issue Feb 27, 2019
@rstoyanchev
RSocketRequester, RSocketStrategies, PayloadUtils
a9d3343 
See spring-projectsgh-21987
rstoyanchev added a commit to rstoyanchev/spring-framework that referenced this issue Feb 27, 2019
@rstoyanchev
MessagingAcceptor/RSocket refinements + upgrade to 0.11.17
fa6c5ff 
See spring-projectsgh-21987
rstoyanchev added a commit to rstoyanchev/spring-framework that referenced this issue Feb 27, 2019
@rstoyanchev
@MessageExceptionHandler supports error signal
0546793 
Before this change if a controller method returned a Publisher whose
first signal was an error, the error signal would not be delegated to
a @MessageExceptionHandler method as expected.

To make this work for now we use a package private local copy of the
ChannelSendOperator from spring-web.

See spring-projectsgh-21987
rstoyanchev added a commit to rstoyanchev/spring-framework that referenced this issue Feb 27, 2019
@rstoyanchev
Refactoring in AbstractMethodMessageHandler
aa75131 
Split out the mechanics of invoking a HandlerMethod and handling the
result into a separate helper class.

See spring-projectsgh-21987
rstoyanchev added a commit to rstoyanchev/spring-framework that referenced this issue Feb 27, 2019
@rstoyanchev
MessagingRSocket delegates to handler Function
fa21d87 
Simplify handling by eliminating the use of a message channel. Instead
MessageHandlerAcceptor now extends from RSocketMessageHandler and
delegates directly to it.

See spring-projectsgh-21987
rstoyanchev added a commit that referenced this issue Mar 5, 2019
@rstoyanchev
Reactive InvocableHandlerMethod in spring-messaging
bcf4f39 
See gh-21987
rstoyanchev added a commit that referenced this issue Mar 5, 2019
@rstoyanchev
Encoder/Decoder based payload serialization
e3e1ffc 
See gh-21987
rstoyanchev added a commit that referenced this issue Mar 5, 2019
@rstoyanchev
Reactive AbstractMessageMethodHandler
421090c 
See gh-21987
rstoyanchev added a commit that referenced this issue Mar 5, 2019
@rstoyanchev
Reactive @MessageMapping
dda40c1 
See gh-21987
rstoyanchev added a commit that referenced this issue Mar 5, 2019
@rstoyanchev
Resolvers for destination vars and headers
567c559 
See gh-21987
rstoyanchev added a commit that referenced this issue Mar 5, 2019
@rstoyanchev
ReactiveMessageChannel and ReactiveSubscribableChannel
33682d7 
See gh-21987
rstoyanchev added a commit that referenced this issue Mar 5, 2019
@rstoyanchev
Payload encoding/decoding and handling refinements
f2bb95b 
See gh-21987
rstoyanchev added a commit that referenced this issue Mar 5, 2019
@rstoyanchev
RSocket @MessageMapping handling
4e78b5d 
See gh-21987
rstoyanchev added a commit that referenced this issue Mar 5, 2019
@rstoyanchev
RSocketRequester, RSocketStrategies, PayloadUtils
8bdd709 
See gh-21987
rstoyanchev added a commit that referenced this issue Mar 5, 2019
@rstoyanchev
MessagingAcceptor/RSocket refinements + upgrade to 0.11.17
d6f4ec8 
See gh-21987
rstoyanchev added a commit that referenced this issue Mar 5, 2019
@rstoyanchev
@MessageExceptionHandler supports error signal
4e1c0c6 
Before this change if a controller method returned a Publisher whose
first signal was an error, the error signal would not be delegated to
a @MessageExceptionHandler method as expected.

To make this work for now we use a package private local copy of the
ChannelSendOperator from spring-web.

See gh-21987
rstoyanchev added a commit that referenced this issue Mar 5, 2019
@rstoyanchev
Refactoring in AbstractMethodMessageHandler
555dca9 
Split out the mechanics of invoking a HandlerMethod and handling the
result into a separate helper class.

See gh-21987
rstoyanchev added a commit that referenced this issue Mar 5, 2019
@rstoyanchev
Direct delegation to RSocketMessageHandler
fa95b01 
Simplify handling by eliminating the use of a message channel. Instead
MessageHandlerAcceptor now extends from RSocketMessageHandler and
delegates directly to it.

See gh-21987
rstoyanchev added a commit that referenced this issue Mar 5, 2019
@rstoyanchev
Explicit handling of void return values
23b39ad 
Do give HandlerMethodReturnValueHandler's a chance to handle return
values so the RSocket reply header is always set.

See gh-21987
rstoyanchev added a commit that referenced this issue Mar 5, 2019
@rstoyanchev
Updates for buffer management in RSocket
9e7f557 
- Integration tests run with zero copy configuration.
- RSocketBufferLeakTests has been added.
- Updates in MessagingRSocket to ensure proper release

See gh-21987
This was referenced May 4, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rstoyanchev rstoyanchev

Labels
in: messaging Issues in messaging modules (jms, messaging) type: task A general task
Projects
None yet
Milestone
5.2 M1
Development

No branches or pull requests
2 participants
@rstoyanchev @spring-projects-issues