PUT nulls Json read-only property [DATAREST-1006]

[spring-projects-issues]

Mathias D opened DATAREST-1006 and commented

Moving to spring data rest Ingalls GA introduces a new problem regarding read only json properties.

We use @JsonProperty(access = READ_ONLY) to mark fields as read-only in our entities. So this field should be serialized but not deserialized.

With Ingalls a PUT request nulls such a property.

I think in a PUT should treat @JsonProperty(access = READ_ONLY) just as @JsonIgnore - so such properts is just ignored in a PUT.

I have added a test on my fork to reproduce the case: mduesterhoeft@c46df6e

---

Affects: 2.6 GA (Ingalls)

Backported to: 3.0.1 (Kay SR1), 2.6.8 (Ingalls SR8)

1 votes, 3 watchers

[spring-projects-issues]

Mathias D commented

This issue is related to FasterXML/jackson-databind#935

This is fixed with jackson-databind 2.8.7-SNAPSHOT (2.8.7 not yet released)

Still I had to add handling of ignored fields to MappedProperties to make it work.

It seems that fields annotated with @JsonIgnore do not show up in BeanDescription.findProperties. A field annotated with @JsonProperty(access = READ_ONLY) does but at the same time it is contained in BeanDescription.getIgnoredPropertyNames

I added another branch to show the solution that can be applied once jackson-databind 2.8.7 is released and spring-data-rest references it.

mduesterhoeft@61ee267

[spring-projects-issues]

Mathias D commented

A workaround that solved it for me is using @ReadOnlyProperty

[spring-projects-issues]

Michael S commented

Any news on this? The fix provided in Mathias D's comment (and PR) looks promising

[spring-projects-issues]

Mathias D commented

Just saw that we have Jackson 2.8.8 now. I will update my PR accordingly

[spring-projects-issues]

Oliver Drotbohm commented

Is there any fix needed at all? You original comment implied it would be fixed with a plain Jackson upgrade, which is why I was basically waiting for its release. Happy to look into what's needed to be done in case there is something

[spring-projects-issues]

Mathias D commented

I had to skip ignored properties in MappedProperties to get it to work

Please see my commit - it contains a test to reproduce the issue.
mduesterhoeft@61ee267

The test is still red on the current master

[spring-projects-issues]

Oliver Drotbohm commented

I'll have a look, thanks

[spring-projects-issues]

Mathias D commented

Just updated the PR #258

[spring-projects-issues]

Oliver Drotbohm commented

That's merged. Feel free to give the snapshots a try

[spring-projects-issues]

Michael S commented

Thanks guys. I stumbled upon a related, but different bug that lets PATCH requests override read-only properties just today: DATAREST-1144