Skip to content

Commit bb91dea

Browse files
committed
Polishing.
Added author tag, JavaDoc and improved test name. See #2540 Original pull request #2542
1 parent d31a03c commit bb91dea

File tree

2 files changed

+15
-7
lines changed

2 files changed

+15
-7
lines changed

src/main/java/org/springframework/data/jpa/provider/HibernateJpaParametersParameterAccessor.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
*
3434
* @author Wonchul Heo
3535
* @author Jens Schauder
36+
* @author Cedomir Igaly
3637
* @since 2.7
3738
*/
3839
class HibernateJpaParametersParameterAccessor extends JpaParametersParameterAccessor {

src/test/java/org/springframework/data/jpa/provider/HibernateJpaParametersParameterAccessorUnitTests.java

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,11 @@
1515
import org.springframework.transaction.TransactionStatus;
1616
import org.springframework.transaction.support.DefaultTransactionDefinition;
1717

18+
/**
19+
* Unit tests for {@link HibernateJpaParametersParameterAccessor}.
20+
*
21+
* @author Cedomir Igaly
22+
*/
1823
@ExtendWith(SpringExtension.class)
1924
@ContextConfiguration("classpath:hjppa-test.xml")
2025
public class HibernateJpaParametersParameterAccessorUnitTests {
@@ -25,23 +30,25 @@ public class HibernateJpaParametersParameterAccessorUnitTests {
2530

2631
@Test
2732
void withoutTransaction() throws NoSuchMethodException {
28-
simpleTest();
33+
parametersCanGetAccessesOutsideTransaction();
2934
}
3035

3136
@Test
3237
void withinTransaction() throws Exception {
33-
final TransactionStatus tx = transactionManager.getTransaction(new DefaultTransactionDefinition());
38+
39+
TransactionStatus tx = transactionManager.getTransaction(new DefaultTransactionDefinition());
3440
try {
35-
simpleTest();
41+
parametersCanGetAccessesOutsideTransaction();
3642
} finally {
3743
transactionManager.rollback(tx);
3844
}
3945
}
4046

41-
private void simpleTest() throws NoSuchMethodException {
42-
final Method method = EntityManager.class.getMethod("flush");
43-
final JpaParameters parameters = new JpaParameters(method);
44-
final HibernateJpaParametersParameterAccessor accessor = new HibernateJpaParametersParameterAccessor(parameters,
47+
private void parametersCanGetAccessesOutsideTransaction() throws NoSuchMethodException {
48+
49+
Method method = EntityManager.class.getMethod("flush");
50+
JpaParameters parameters = new JpaParameters(method);
51+
HibernateJpaParametersParameterAccessor accessor = new HibernateJpaParametersParameterAccessor(parameters,
4552
new Object[] {}, em);
4653
Assertions.assertEquals(0, accessor.getValues().length);
4754
Assertions.assertEquals(parameters, accessor.getParameters());

0 commit comments

Comments
 (0)