Obtain merged annotation for annotation validation.

We now validate declared annotations by pre-processing these through AnnotatedElementUtils to ensure a proper comparison. Previously, we compared annotation in their declared form (AnnotatedElement.getAnnotations()) with merged annotations which could fail due to aliasing effects of merged annotations.

Closes #2368.

Author: mp911de

src/main/java/org/springframework/data/mapping/model/AnnotationBasedPersistentProperty.java

@@ -107,13 +107,15 @@ private void populateAnnotationCache(Property property) {
 
 				Class<? extends Annotation> annotationType = annotation.annotationType();
 
-				validateAnnotation(annotation,
+				Annotation mergedAnnotation = AnnotatedElementUtils.getMergedAnnotation(it, annotationType);
+
+				validateAnnotation(mergedAnnotation,
 						"Ambiguous mapping! Annotation %s configured "
 								+ "multiple times on accessor methods of property %s in class %s!",
 						annotationType.getSimpleName(), getName(), getOwner().getType().getSimpleName());
 
 				annotationCache.put(annotationType,
-						Optional.ofNullable(AnnotatedElementUtils.findMergedAnnotation(it, annotationType)));
+						Optional.of(mergedAnnotation));
 			}
 		});
 
@@ -122,13 +124,14 @@ private void populateAnnotationCache(Property property) {
 			for (Annotation annotation : it.getAnnotations()) {
 
 				Class<? extends Annotation> annotationType = annotation.annotationType();
+				Annotation mergedAnnotation = AnnotatedElementUtils.getMergedAnnotation(it, annotationType);
 
-				validateAnnotation(annotation,
+				validateAnnotation(mergedAnnotation,
 						"Ambiguous mapping! Annotation %s configured " + "on field %s and one of its accessor methods in class %s!",
 						annotationType.getSimpleName(), it.getName(), getOwner().getType().getSimpleName());
 
 				annotationCache.put(annotationType,
-						Optional.ofNullable(AnnotatedElementUtils.findMergedAnnotation(it, annotationType)));
+						Optional.of(mergedAnnotation));
 			}
 		});
 	}

src/test/java/org/springframework/data/mapping/model/AnnotationBasedPersistentPropertyUnitTests.java

@@ -331,6 +331,7 @@ public String getGetter() {
 		}
 
 		@MyAnnotation
+		@RevisedAnnnotationWithAliasFor(value = "my-value")
 		public void setSetter(String setter) {
 			this.setter = setter;
 		}