Skip to content

Upgrade to Jackson 2.9.9 #16910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wilkinsona opened this issue May 21, 2019 · 4 comments
Closed

Upgrade to Jackson 2.9.9 #16910

wilkinsona opened this issue May 21, 2019 · 4 comments
Labels
type: dependency-upgrade A dependency upgrade
Milestone
2.1.6

Comments

@wilkinsona
Copy link
Member

No description provided.

@wilkinsona wilkinsona added this to the 2.1.6 milestone May 21, 2019
@wilkinsona wilkinsona added the type: dependency-upgrade A dependency upgrade label May 21, 2019
@wilkinsona
Copy link
Member Author

wilkinsona commented May 21, 2019 •
edited
Loading

This has broken some Hibernate functionality as it results in an incompatible combination of versions of woodstox-core and stax2-api. See FasterXML/jackson-dataformat-xml#340 for details. We could, roll back to 2.9.8, manage the stax2-api dependency to force it to 4.1, or manage the woodstox-core dependency to downgrade it to 5.0.x.

@wilkinsona wilkinsona reopened this May 21, 2019
@wilkinsona wilkinsona mentioned this issue May 21, 2019
Closed
wilkinsona added a commit that referenced this issue May 21, 2019
@wilkinsona
Revert "Upgrade to Jackson 2.9.9"
6c7a6a6 
This reverts commit 66fba93.

See gh-16910
@varunnvs92 varunnvs92 mentioned this issue May 28, 2019
Closed
13 tasks
@wilkinsona
Copy link
Member Author

Both an upgrade of StAX 2 API or a downgrade of Woodstox are viable options. I think we should downgrade Woodstox as that will leave the dependencies closer to how they are with Jackson 2.9.8.

@wilkinsona
Copy link
Member Author

wilkinsona commented Jun 12, 2019 •
edited
Loading

Jackson has gone the other way and is planning to move from stax2-api 3.1.4 to stax2-api 4.1 in 2.9.10. I wonder if we should do that instead?

@wilkinsona wilkinsona reopened this Jun 12, 2019
@wilkinsona wilkinsona added the for: team-attention An issue we'd like other members of the team to review label Jun 12, 2019
@wilkinsona
Copy link
Member Author

stax2-api 4.1 is binary incompatible with 3.1.4 so we should stick with the Woodstox downgrade.

@wilkinsona wilkinsona removed the for: team-attention An issue we'd like other members of the team to review label Jun 12, 2019
@wilkinsona wilkinsona mentioned this issue Oct 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: dependency-upgrade A dependency upgrade
Projects
None yet
Milestone
2.1.6
Development

No branches or pull requests
1 participant
@wilkinsona