Skip to content

Consider Protobuf codecs auto-configuration for RSocket support #16281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bclozel opened this issue Mar 21, 2019 · 1 comment
Open

Consider Protobuf codecs auto-configuration for RSocket support #16281

bclozel opened this issue Mar 21, 2019 · 1 comment
Labels
type: enhancement A general enhancement
Milestone

Comments

@bclozel
Copy link
Member

bclozel commented Mar 21, 2019

As of #16021, Spring Boot supports RSocket as a server. Protobuf is a popular solution for messages (de)serialization and it seems to align well with the RSocket paradigm.

This issue should consider whether and how we should:

  • auto-configure Protobuf codecs for RSocket
  • provide configuration properties
  • provide dependency management
  • do additional work in the Spring Boot application builds
@bclozel bclozel added the type: enhancement A general enhancement label Mar 21, 2019
@bclozel bclozel added this to the 2.2.x milestone Mar 21, 2019
@bclozel bclozel self-assigned this Mar 21, 2019
@philwebb philwebb added the for: team-attention An issue we'd like other members of the team to review label May 24, 2019
@philwebb philwebb removed the for: team-attention An issue we'd like other members of the team to review label May 29, 2019
@philwebb philwebb modified the milestones: 2.2.x, 2.x May 29, 2019
@eiswind
Copy link

eiswind commented Dec 25, 2019

As of 2.2.2 I had to disable RSocketServerAutoConfiguration and add:

    @Bean
    CloseableChannel server(GreetingServiceServer serviceServer){
        return RSocketFactory
                .receive()
                .acceptor((setup, sendingSocket) -> Mono.just(
                        new RequestHandlingRSocket(serviceServer)
                ))
                .transport(TcpServerTransport.create(serverPort))
                .start()
                .block();
    }

I did not manage to use a protobuf service and a spring messagehandler in the same application.

Perhaps it is possible to autodetect the rpc-services?

@philwebb philwebb modified the milestones: 2.x, 3.x Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants