Skip to content

Commit 736a209

Browse files
committed
Upgrade to Spring Session 2.0.0.M4
Closes gh-10125
1 parent 9dd3fb7 commit 736a209

File tree

5 files changed

+17
-12
lines changed

5 files changed

+17
-12
lines changed

spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/session/NonUniqueSessionRepositoryException.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,25 +23,25 @@
2323
import org.springframework.util.ObjectUtils;
2424

2525
/**
26-
* Exception thrown when multiple {@link SessionRepository} implementations are
27-
* available with no way to know which implementation should be used.
26+
* Exception thrown when multiple {@link SessionRepository} implementations are available
27+
* with no way to know which implementation should be used.
2828
*
2929
* @author Stephane Nicoll
3030
* @since 2.0.0
3131
*/
3232
public class NonUniqueSessionRepositoryException extends RuntimeException {
3333

34-
private final List<Class<? extends SessionRepository>> availableCandidates;
34+
private final List<Class<? extends SessionRepository<?>>> availableCandidates;
3535

3636
public NonUniqueSessionRepositoryException(
37-
List<Class<? extends SessionRepository>> availableCandidates) {
37+
List<Class<? extends SessionRepository<?>>> availableCandidates) {
3838
super("Multiple session repository candidates are available, set the "
3939
+ "'spring.session.store-type' property accordingly");
4040
this.availableCandidates = (!ObjectUtils.isEmpty(availableCandidates)
4141
? availableCandidates : Collections.emptyList());
4242
}
4343

44-
public List<Class<? extends SessionRepository>> getAvailableCandidates() {
44+
public List<Class<? extends SessionRepository<?>>> getAvailableCandidates() {
4545
return this.availableCandidates;
4646
}
4747

spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/session/NonUniqueSessionRepositoryFailureAnalyzer.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,8 @@ protected FailureAnalysis analyze(Throwable rootFailure,
3434
StringBuilder message = new StringBuilder();
3535
message.append(String.format("Multiple Spring Session store implementations are "
3636
+ "available on the classpath:%n"));
37-
for (Class<? extends SessionRepository> candidate : cause.getAvailableCandidates()) {
37+
for (Class<? extends SessionRepository<?>> candidate : cause
38+
.getAvailableCandidates()) {
3839
message.append(String.format(" - %s%n", candidate.getName()));
3940
}
4041
StringBuilder action = new StringBuilder();

spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/session/SessionAutoConfiguration.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ static class SessionRepositoryImplementationValidator {
106106

107107
@PostConstruct
108108
public void checkAvailableImplementations() {
109-
List<Class<? extends SessionRepository>> candidates = new ArrayList<>();
109+
List<Class<? extends SessionRepository<?>>> candidates = new ArrayList<>();
110110
addCandidate(candidates,
111111
"org.springframework.session.hazelcast.HazelcastSessionRepository");
112112
addCandidate(candidates,
@@ -119,10 +119,12 @@ public void checkAvailableImplementations() {
119119
}
120120
}
121121

122-
private void addCandidate(
123-
List<Class<? extends SessionRepository>> candidates, String fqn) {
122+
@SuppressWarnings("unchecked")
123+
private void addCandidate(List<Class<? extends SessionRepository<?>>> candidates,
124+
String fqn) {
124125
try {
125-
Class<? extends SessionRepository> candidate = (Class<? extends SessionRepository>) this.classLoader.loadClass(fqn);
126+
Class<? extends SessionRepository<?>> candidate = (Class<? extends SessionRepository<?>>) this.classLoader
127+
.loadClass(fqn);
126128
if (candidate != null) {
127129
candidates.add(candidate);
128130
}

spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/session/NonUniqueSessionRepositoryFailureAnalyzerTests.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,9 @@ public void failureAnalysisWithMultipleCandidates() {
4949
assertThat(analysis.getAction()).contains("spring.session.store-type");
5050
}
5151

52-
private Exception createFailure(Class<? extends SessionRepository>... candidates) {
52+
@SafeVarargs
53+
private final Exception createFailure(
54+
Class<? extends SessionRepository<?>>... candidates) {
5355
return new NonUniqueSessionRepositoryException(Arrays.asList(candidates));
5456
}
5557

spring-boot-dependencies/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@
174174
<spring-security.version>5.0.0.M3</spring-security.version>
175175
<spring-security-jwt.version>1.0.8.RELEASE</spring-security-jwt.version>
176176
<spring-security-oauth.version>2.2.0.RELEASE</spring-security-oauth.version>
177-
<spring-session.version>2.0.0.M3</spring-session.version>
177+
<spring-session.version>2.0.0.M4</spring-session.version>
178178
<spring-social.version>2.0.0.M3</spring-social.version>
179179
<spring-social-facebook.version>3.0.0.M2</spring-social-facebook.version>
180180
<spring-social-linkedin.version>2.0.0.M2</spring-social-linkedin.version>

0 commit comments

Comments
 (0)