Skip to content

Commit 82413f4

Browse files
committed
Fix tests
1 parent e2fca4c commit 82413f4

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

oauth2-authorization-server/src/test/java/org/springframework/security/oauth2/server/authorization/oidc/web/OidcProviderConfigurationEndpointFilterTests.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,9 @@
2727
import org.springframework.security.oauth2.server.authorization.context.AuthorizationServerContextHolder;
2828
import org.springframework.security.oauth2.server.authorization.context.TestAuthorizationServerContext;
2929
import org.springframework.security.oauth2.server.authorization.settings.AuthorizationServerSettings;
30+
import org.springframework.web.util.InvalidUrlException;
3031

3132
import static org.assertj.core.api.Assertions.assertThat;
32-
import static org.assertj.core.api.Assertions.assertThatIllegalArgumentException;
3333
import static org.assertj.core.api.Assertions.assertThatThrownBy;
3434
import static org.mockito.ArgumentMatchers.any;
3535
import static org.mockito.Mockito.mock;
@@ -171,8 +171,8 @@ public void doFilterWhenAuthorizationServerSettingsWithInvalidIssuerThenThrowIll
171171
MockHttpServletResponse response = new MockHttpServletResponse();
172172
FilterChain filterChain = mock(FilterChain.class);
173173

174-
assertThatIllegalArgumentException().isThrownBy(() -> this.filter.doFilter(request, response, filterChain))
175-
.withMessage("issuer must be a valid URL");
174+
assertThatThrownBy(() -> this.filter.doFilter(request, response, filterChain))
175+
.isInstanceOf(InvalidUrlException.class);
176176
}
177177

178178
}

oauth2-authorization-server/src/test/java/org/springframework/security/oauth2/server/authorization/web/OAuth2AuthorizationServerMetadataEndpointFilterTests.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,9 @@
2727
import org.springframework.security.oauth2.server.authorization.context.AuthorizationServerContextHolder;
2828
import org.springframework.security.oauth2.server.authorization.context.TestAuthorizationServerContext;
2929
import org.springframework.security.oauth2.server.authorization.settings.AuthorizationServerSettings;
30+
import org.springframework.web.util.InvalidUrlException;
3031

3132
import static org.assertj.core.api.Assertions.assertThat;
32-
import static org.assertj.core.api.Assertions.assertThatIllegalArgumentException;
3333
import static org.assertj.core.api.Assertions.assertThatThrownBy;
3434
import static org.mockito.ArgumentMatchers.any;
3535
import static org.mockito.Mockito.mock;
@@ -161,8 +161,8 @@ public void doFilterWhenAuthorizationServerSettingsWithInvalidIssuerThenThrowIll
161161
MockHttpServletResponse response = new MockHttpServletResponse();
162162
FilterChain filterChain = mock(FilterChain.class);
163163

164-
assertThatIllegalArgumentException().isThrownBy(() -> this.filter.doFilter(request, response, filterChain))
165-
.withMessage("issuer must be a valid URL");
164+
assertThatThrownBy(() -> this.filter.doFilter(request, response, filterChain))
165+
.isInstanceOf(InvalidUrlException.class);
166166
}
167167

168168
}

oauth2-authorization-server/src/test/java/org/springframework/security/oauth2/server/authorization/web/OAuth2DeviceAuthorizationEndpointFilterTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@
7373
*/
7474
public class OAuth2DeviceAuthorizationEndpointFilterTests {
7575

76-
private static final String ISSUER_URI = "https://provider.com";
76+
private static final String ISSUER_URI = "https://provider.com:8090";
7777

7878
private static final String REMOTE_ADDRESS = "remote-address";
7979

@@ -417,7 +417,7 @@ private static MockHttpServletRequest createRequest() {
417417
request.setRemoteAddr(REMOTE_ADDRESS);
418418
request.setScheme("https");
419419
request.setServerName("provider.com");
420-
request.setServerPort(-1);
420+
request.setServerPort(8090);
421421
return request;
422422
}
423423

0 commit comments

Comments
 (0)