From 56174b34920ff39eca5fb7742214b038005be989 Mon Sep 17 00:00:00 2001 From: shauli Date: Wed, 10 Jan 2024 12:25:45 +0200 Subject: [PATCH] ami auto update --- api/services/ocean/aws/responses/amiAutoUpdate.yaml | 8 ++++---- api/services/ocean/aws/schemas/amiAutoUpdate.yaml | 2 +- api/services/ocean/aws/schemas/amiAutoUpdateData.yaml | 2 +- api/services/ocean/aws/schemas/amiAutoUpdateSummery.yaml | 4 ++-- api/services/ocean/aws/schemas/ocean-scheduling.yaml | 4 ++-- 5 files changed, 10 insertions(+), 10 deletions(-) diff --git a/api/services/ocean/aws/responses/amiAutoUpdate.yaml b/api/services/ocean/aws/responses/amiAutoUpdate.yaml index 5d17a7753..a02835447 100644 --- a/api/services/ocean/aws/responses/amiAutoUpdate.yaml +++ b/api/services/ocean/aws/responses/amiAutoUpdate.yaml @@ -1,5 +1,5 @@ -description: Ocean Cluster Aggregated Summary Costs Response -# todo shauli - Aggregated Summary Costs? +description: EKS AMI Auto Update Response +# todo shauli - Aggregated Summary Costs? Fixed content: application/json: schema: @@ -11,8 +11,8 @@ content: type: object properties: url: - example: "/ocean/aws/k8s/cluster/o-abcd1234/aggregatedCosts/summary" - # todo shauli - aggregatedCosts? + example: "/ocean/aws/eks/cluster/o-abcd1234/amiAutoUpdate" + # todo shauli - aggregatedCosts? Fixed method: example: "POST" response: diff --git a/api/services/ocean/aws/schemas/amiAutoUpdate.yaml b/api/services/ocean/aws/schemas/amiAutoUpdate.yaml index 63699bfaa..0b15e201a 100644 --- a/api/services/ocean/aws/schemas/amiAutoUpdate.yaml +++ b/api/services/ocean/aws/schemas/amiAutoUpdate.yaml @@ -33,7 +33,7 @@ properties: type: integer description: Indicates the threshold of minimum healthy instances in single batch. If the amount of healthy instances in single batch is under the threshold, the cluster roll will fail. If exists, the parameter value will be in range of 1-100. In case of null as value, the default value in the backend will be 50%. Value of param should represent the number in percentage (%) of the batch. example: 100 - #todo shauli - if default exist, add default field. + #todo shauli - if default exist, add default field. fixed comment: type: string description: > diff --git a/api/services/ocean/aws/schemas/amiAutoUpdateData.yaml b/api/services/ocean/aws/schemas/amiAutoUpdateData.yaml index dee7bc1bb..03d67509f 100644 --- a/api/services/ocean/aws/schemas/amiAutoUpdateData.yaml +++ b/api/services/ocean/aws/schemas/amiAutoUpdateData.yaml @@ -40,4 +40,4 @@ properties: example: ami-019e5b81636e5a350 description: | The ID of the new AMI that is being used for the VNG. - #todo shauli - what will it show if it's double ami in the vng? or this is not relevant? \ No newline at end of file + #todo shauli - what will it show if it's double ami in the vng? or this is not relevant? fixed \ No newline at end of file diff --git a/api/services/ocean/aws/schemas/amiAutoUpdateSummery.yaml b/api/services/ocean/aws/schemas/amiAutoUpdateSummery.yaml index 625d3cc4d..8fff7c792 100644 --- a/api/services/ocean/aws/schemas/amiAutoUpdateSummery.yaml +++ b/api/services/ocean/aws/schemas/amiAutoUpdateSummery.yaml @@ -14,7 +14,7 @@ properties: description: > Ami update result. enum: [ Success, Failed ] - #todo shauli - verify lower-upper casing + #todo shauli - verify lower-upper casing fixed data: type: array items: @@ -31,7 +31,7 @@ properties: example: 2024-01-02T09:57:09.211Z description: | The AMI update method was triggered at this time. - #todo shauli - not create method? + #todo shauli - not create method? need to discuss updatedAt: type: string readOnly: true diff --git a/api/services/ocean/aws/schemas/ocean-scheduling.yaml b/api/services/ocean/aws/schemas/ocean-scheduling.yaml index 0d8d1f0f2..5c69fc1fe 100644 --- a/api/services/ocean/aws/schemas/ocean-scheduling.yaml +++ b/api/services/ocean/aws/schemas/ocean-scheduling.yaml @@ -28,14 +28,14 @@ properties: taskType: type: string example: clusterRoll / amiAutoUpdate - #todo shauli - why both of the enum in the example? there can be only one in a request + #todo shauli - why both of the enum in the example? there can be only one in a request need to discuss enum: ["clusterRoll", "amiAutoUpdate"] description: > The activity that you are scheduling. Valid values: "clusterRoll", "amiAutoUpdate". Required for cluster.scheduling.tasks. parameters: type: object properties: - #todo shauli - clusterRoll tree object appears twice in here - verifying this is intentional + #todo shauli - clusterRoll tree object appears twice in here - verifying this is intentional need to discuss clusterRoll: type: object properties: