build: updates to fix maven deploy #99
Merged
+37
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove thing from pom fixups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was problematic before was party the fact that we had multi line secrets that we tried to mount as secrets in docker.
This approach writes them to tmp files in github workflows first and then mounts them as
secret-filesin docker instead.Additionally the PR bumps the
maven-gpg-pluginto a newer version where we can useMAVEN_GPG_PASSPHRASEenv var.Also bumping the docker syntax allows us to mount the gpg password secret directly to said environment var in docker.