Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to check the validity of Typescript code in Tutorial section #52

Open
ashuralyk opened this issue Jan 29, 2024 · 3 comments
Open
Labels
question Further information is requested

Comments

@ashuralyk
Copy link
Contributor

Description

after spore-sdk bumped a few versions ahead, I want to know wether our guide code in Tutorial needs to be adapted @ShookLyngs

@ashuralyk ashuralyk added the question Further information is requested label Jan 29, 2024
@ShookLyngs
Copy link
Contributor

The on-chain blog tutorial code has been updated, the last adaptation: sporeprotocol/spore-scrum#18
The first-example tutorial code should be fine, but the tutorial has mentioned a v1 spore, which is a legacy version and cannot be queried via spore-graphql. See issue: sporeprotocol/spore-graphql#11.

@ashuralyk
Copy link
Contributor Author

The on-chain blog tutorial code has been updated, the last adaptation: sporeprotocol/spore-scrum#18 The first-example tutorial code should be fine, but the tutorial has mentioned a v1 spore, which is a legacy version and cannot be queried via spore-graphql. See issue: sporeprotocol/spore-graphql#11.

ok, how about we just use a v2 spore to replace this v1 spore in tutorial?

@ShookLyngs
Copy link
Contributor

ok, how about we just use a v2 spore to replace this v1 spore in tutorial?

Yeah, I think that works too if upgrading the spore-graphql is not urgent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants