144867444998371 dual cookie redis split persistence adapter (#420)

* Use fakeredis for testing

* require fakeredis manually

* Add fakeredis as a dev dependency

* v.1.5.0

* Add Dual Redis(logged-in)/cookie(logged-out) persistence adapter

Author: karmakaze

CHANGELOG.md

@@ -1,3 +1,14 @@
+## 1.5.0 (June 8th, 2016)
+
+Features:
+
+- Add `expire_seconds:` TTL option to RedisAdapter (@karmakaze, #409)
+- Optional custom persistence adapter (@ndelage, #411)
+
+Misc:
+
+- Use fakeredis for testing (@andrew, #412)
+
 ## 1.4.5 (June 7th, 2016)
 
 Bugfixes:

README.md

@@ -223,6 +223,25 @@ Options:
 * `namespace`: separate namespace to store these persisted values (default "persistence")
 * `expire_seconds`: sets TTL for user key. (if a user is in multiple experiments most recent update will reset TTL for all their assignments)
 
+#### Dual Adapter
+
+The Dual Adapter allows the use of different persistence adapters for logged-in and logged-out users. A common use case is to use Redis for logged-in users and Cookies for logged-out users.
+
+```ruby
+cookie_adapter = Split::Persistence::CookieAdapter
+redis_adapter = Split::Persistence::RedisAdapter.with_config(
+    lookup_by: -> (context) { context.send(:current_user).try(:id) },
+    expire_seconds: 2592000)
+
+Split.configure do |config|
+  config.persistence = Split::Persistence::DualAdapter.with_config(
+      logged_in: -> (context) { !context.send(:current_user).try(:id).nil? },
+      logged_in_adapter: redis_adapter,
+      logged_out_adapter: cookie_adapter)
+  config.persistence_cookie_length = 2592000 # 30 days
+end
+```
+
 #### Custom Adapter
 
 Your custom adapter needs to implement the same API as existing adapters.

lib/split/persistence.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-%w[session_adapter cookie_adapter redis_adapter].each do |f|
+%w[session_adapter cookie_adapter redis_adapter dual_adapter].each do |f|
   require "split/persistence/#{f}"
 end
 

lib/split/persistence/dual_adapter.rb

@@ -0,0 +1,40 @@
+# frozen_string_literal: true
+module Split
+  module Persistence
+    class DualAdapter
+      extend Forwardable
+      def_delegators :@adapter, :keys, :[], :[]=, :delete
+
+      def initialize(context)
+        if logged_in = self.class.config[:logged_in]
+        else
+          raise "Please configure :logged_in"
+        end
+        if logged_in_adapter = self.class.config[:logged_in_adapter]
+        else
+          raise "Please configure :logged_in_adapter"
+        end
+        if logged_out_adapter = self.class.config[:logged_out_adapter]
+        else
+          raise "Please configure :logged_out_adapter"
+        end
+
+        if logged_in.call(context)
+          @adapter = logged_in_adapter.new(context)
+        else
+          @adapter = logged_out_adapter.new(context)
+        end
+      end
+
+      def self.with_config(options={})
+        self.config.merge!(options)
+        self
+      end
+
+      def self.config
+        @config ||= {}
+      end
+
+    end
+  end
+end

lib/split/version.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 module Split
   MAJOR   = 1
-  MINOR   = 4
-  PATCH   = 5
+  MINOR   = 5
+  PATCH   = 0
   VERSION = [MAJOR, MINOR, PATCH].join('.')
 end