Skip to content

Commit 64fa5a3

Browse files
committed
Improved spec handling
1 parent ea58a8d commit 64fa5a3

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ require (
88
github.com/gin-gonic/gin v1.10.0
99
github.com/google/uuid v1.3.0
1010
github.com/splitio/gincache v1.0.1
11-
github.com/splitio/go-split-commons/v6 v6.1.1-0.20250414224340-9a5c36389db1
11+
github.com/splitio/go-split-commons/v6 v6.1.1-0.20250415223836-55f450ca303b
1212
github.com/splitio/go-toolkit/v5 v5.4.0
1313
github.com/stretchr/testify v1.9.0
1414
go.etcd.io/bbolt v1.3.6

go.sum

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,8 @@ github.com/splitio/gincache v1.0.1 h1:dLYdANY/BqH4KcUMCe/LluLyV5WtuE/LEdQWRE06IX
9595
github.com/splitio/gincache v1.0.1/go.mod h1:CcgJDSM9Af75kyBH0724v55URVwMBuSj5x1eCWIOECY=
9696
github.com/splitio/go-split-commons/v6 v6.1.1-0.20250414224340-9a5c36389db1 h1:le2tNqtYsipMP5PQgJWAtu3x5DbPzquYT36RUeiiVfY=
9797
github.com/splitio/go-split-commons/v6 v6.1.1-0.20250414224340-9a5c36389db1/go.mod h1:D/XIY/9Hmfk9ivWsRsJVp439kEdmHbzUi3PKzQQDOXY=
98+
github.com/splitio/go-split-commons/v6 v6.1.1-0.20250415223836-55f450ca303b h1:vAuwe1IFSCJNGnx/BFwnGyleKTQRcCmypV8DIwkA3fM=
99+
github.com/splitio/go-split-commons/v6 v6.1.1-0.20250415223836-55f450ca303b/go.mod h1:D/XIY/9Hmfk9ivWsRsJVp439kEdmHbzUi3PKzQQDOXY=
98100
github.com/splitio/go-toolkit/v5 v5.4.0 h1:g5WFpRhQomnXCmvfsNOWV4s5AuUrWIZ+amM68G8NBKM=
99101
github.com/splitio/go-toolkit/v5 v5.4.0/go.mod h1:xYhUvV1gga9/1029Wbp5pjnR6Cy8nvBpjw99wAbsMko=
100102
github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=

splitio/proxy/controllers/sdk.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -124,9 +124,8 @@ func (c *SdkServerController) SplitChanges(ctx *gin.Context) {
124124
sParam, _ := ctx.GetQuery("s")
125125
spec, err := specs.ParseAndValidate(sParam)
126126
if err != nil {
127-
c.logger.Error(fmt.Sprintf("error parsing spec version: %s.", err))
128-
ctx.JSON(http.StatusBadRequest, gin.H{"code": 400, "message": err.Error()})
129-
return
127+
c.logger.Error(fmt.Sprintf("error parsing spec version: %s. Defaulting to: %s", err, specs.Latest))
128+
spec = specs.Latest
130129
}
131130

132131
splits.Splits = c.patchUnsupportedMatchers(splits.Splits, spec)

splitio/proxy/controllers/sdk_test.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ import (
1414
"github.com/splitio/go-split-commons/v6/engine/grammar"
1515
"github.com/splitio/go-split-commons/v6/engine/grammar/matchers"
1616
"github.com/splitio/go-split-commons/v6/service"
17-
"github.com/splitio/go-split-commons/v6/service/api/specs"
1817
cmnStorage "github.com/splitio/go-split-commons/v6/storage"
1918
"github.com/splitio/go-toolkit/v5/logging"
2019
"github.com/stretchr/testify/assert"
@@ -440,7 +439,7 @@ func TestSplitChangesNewMatcherNewSpec(t *testing.T) {
440439
ctx.Request.Header.Set("SplitSDKMachineIp", "1.2.3.4")
441440
ctx.Request.Header.Set("SplitSDKMachineName", "ip-1-2-3-4")
442441
q := ctx.Request.URL.Query()
443-
q.Add("s", specs.FLAG_V1_1)
442+
q.Add("s", "1.1")
444443
ctx.Request.URL.RawQuery = q.Encode()
445444
router.ServeHTTP(resp, ctx.Request)
446445

0 commit comments

Comments
 (0)