Skip to content

Commit bb0c197

Browse files
Fix some links, and refactor for lazy initialization
1 parent 3d9c4ec commit bb0c197

File tree

5 files changed

+14
-12
lines changed

5 files changed

+14
-12
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ This library is compatible with JavaScript ES5 and above.
1414
Please see [Contributors Guide](CONTRIBUTORS-GUIDE.md) to find all you need to submit a Pull Request (PR).
1515

1616
## License
17-
Licensed under the Apache License, Version 2.0. See: [Apache License](http://www.apache.org/licenses/).
17+
Licensed under the Apache License, Version 2.0. See: [Apache License](https://www.apache.org/licenses/).
1818

1919
## About Split
2020

@@ -46,4 +46,4 @@ For a comprehensive list of open source projects visit our [Github page](https:/
4646

4747
**Learn more about Split:**
4848

49-
Visit [split.io/product](https://www.split.io/product) for an overview of Split, or visit our documentation at [help.split.io](http://help.split.io) for more detailed information.
49+
Visit [split.io/product](https://www.split.io/product) for an overview of Split, or visit our documentation at [help.split.io](https://help.split.io) for more detailed information.

src/sync/streaming/pushManager.ts

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -349,12 +349,14 @@ export function pushManagerFactory(
349349
// Reconnects in case of a new client.
350350
// Run in next event-loop cycle to save authentication calls
351351
// in case multiple clients are created in the current cycle.
352-
setTimeout(function checkForReconnect() {
353-
if (connectForNewClient) {
354-
connectForNewClient = false;
355-
connectPush();
356-
}
357-
}, 0);
352+
if (this.isRunning()) {
353+
setTimeout(function checkForReconnect() {
354+
if (connectForNewClient) {
355+
connectForNewClient = false;
356+
connectPush();
357+
}
358+
}, 0);
359+
}
358360
}
359361
},
360362
// [Only for client-side]

src/sync/syncManagerOnline.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -142,19 +142,19 @@ export function syncManagerOnlineFactory(
142142
if (!pollingManager) return;
143143

144144
const mySegmentsSyncTask = (pollingManager as IPollingManagerCS).add(matchingKey, readinessManager, storage);
145+
if (syncEnabled && pushManager) pushManager.add(matchingKey, mySegmentsSyncTask);
145146

146147
if (running) {
147148
if (syncEnabled) {
148149
if (pushManager) {
149-
if (pollingManager!.isRunning()) {
150+
if (pollingManager.isRunning()) {
150151
// if doing polling, we must start the periodic fetch of data
151152
if (storage.splits.usesSegments()) mySegmentsSyncTask.start();
152153
} else {
153154
// if not polling, we must execute the sync task for the initial fetch
154155
// of segments since `syncAll` was already executed when starting the main client
155156
mySegmentsSyncTask.execute();
156157
}
157-
pushManager.add(matchingKey, mySegmentsSyncTask);
158158
} else {
159159
if (storage.splits.usesSegments()) mySegmentsSyncTask.start();
160160
}

types/index.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// Declaration file for JavaScript Browser Split Software SDK
2-
// Project: http://www.split.io/
2+
// Project: https://www.split.io/
33
// Definitions by: Nico Zelaya <https://github.com/NicoZelaya/>
44

55
/// <reference path="./splitio.d.ts" />

types/splitio.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// Type definitions for Split Software SDKs
2-
// Project: http://www.split.io/
2+
// Project: https://www.split.io/
33

44
import { RedisOptions } from 'ioredis';
55
import { RequestOptions } from 'http';

0 commit comments

Comments
 (0)