Skip to content

Commit 55f289d

Browse files
Merge pull request #371 from splitio/polishing
General polishing
2 parents 92ed5ed + 3d9c4ec commit 55f289d

File tree

8 files changed

+13
-11
lines changed

8 files changed

+13
-11
lines changed

src/listeners/node.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ export class NodeSignalListener implements ISignalListener {
5656
// Cleaned up, remove handlers.
5757
this.stop();
5858

59-
// This handler prevented the default behaviour, start again.
59+
// This handler prevented the default behavior, start again.
6060
// eslint-disable-next-line no-undef
6161
process.kill(process.pid, SIGTERM);
6262
};
@@ -72,7 +72,7 @@ export class NodeSignalListener implements ISignalListener {
7272
}
7373

7474
if (thenable(handlerResult)) {
75-
// Always exit, even with errors. The promise is returned for UT purposses.
75+
// Always exit, even with errors. The promise is returned for UT purposes.
7676
return handlerResult.then(wrapUp).catch(wrapUp);
7777
} else {
7878
wrapUp();

src/logger/__tests__/index.spec.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -97,22 +97,22 @@ function testLogLevels(levelToTest: SplitIO.LogLevel) {
9797

9898
}
9999

100-
test('SPLIT LOGGER / Logger class public methods behaviour - instance.debug', () => {
100+
test('SPLIT LOGGER / Logger class public methods behavior - instance.debug', () => {
101101
testLogLevels(LogLevels.DEBUG);
102102

103103
});
104104

105-
test('SPLIT LOGGER / Logger class public methods behaviour - instance.info', () => {
105+
test('SPLIT LOGGER / Logger class public methods behavior - instance.info', () => {
106106
testLogLevels(LogLevels.INFO);
107107

108108
});
109109

110-
test('SPLIT LOGGER / Logger class public methods behaviour - instance.warn', () => {
110+
test('SPLIT LOGGER / Logger class public methods behavior - instance.warn', () => {
111111
testLogLevels(LogLevels.WARN);
112112

113113
});
114114

115-
test('SPLIT LOGGER / Logger class public methods behaviour - instance.error', () => {
115+
test('SPLIT LOGGER / Logger class public methods behavior - instance.error', () => {
116116
testLogLevels(LogLevels.ERROR);
117117

118118
});

src/readiness/__tests__/readinessManager.spec.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -214,6 +214,8 @@ test('READINESS MANAGER / Cancel timeout if ready fired', (done) => {
214214

215215
const readinessManager = readinessManagerFactory(EventEmitter, settingsWithTimeout);
216216
readinessManager.init(); // Start the timeout
217+
readinessManager.destroy(); // Should cancel the timeout
218+
readinessManager.init(); // Start the timeout again
217219

218220
readinessManager.gate.on(SDK_READY_TIMED_OUT, () => { sdkReadyTimedoutCalled = true; });
219221
readinessManager.gate.once(SDK_READY, () => { sdkReadyCalled = true; });

src/readiness/__tests__/sdkReadinessManager.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ describe('SDK Readiness Manager - Event emitter', () => {
201201

202202
describe('SDK Readiness Manager - Ready promise', () => {
203203

204-
test('.ready() promise behaviour for clients', async () => {
204+
test('.ready() promise behavior for clients', async () => {
205205
const sdkReadinessManager = sdkReadinessManagerFactory(EventEmitterMock, fullSettings);
206206

207207
const ready = sdkReadinessManager.sdkStatus.ready();

src/storages/inRedis/__tests__/RedisAdapter.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ describe('STORAGE Redis Adapter', () => {
181181

182182
expect(ioredisMock.once).toBeCalledTimes(2); // If the method was called, it should have called the `once` function twice. If that it the case we can assume that the method was called on creation.
183183

184-
// Reset stubs again, we'll check the behaviour calling the method directly.
184+
// Reset stubs again, we'll check the behavior calling the method directly.
185185
clearAllMocks();
186186
expect(ioredisMock.once).not.toBeCalled(); // Control assertion
187187
expect(ioredisMock[METHODS_TO_PROMISE_WRAP[METHODS_TO_PROMISE_WRAP.length - 1]]).not.toBeCalled(); // Control assertion

src/trackers/eventTracker.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ export function eventTrackerFactory(
3636
whenInit(() => {
3737
// Wrap in a timeout because we don't want it to be blocking.
3838
setTimeout(() => {
39-
// copy of event, to avoid unexpected behaviour if modified by integrations
39+
// copy of event, to avoid unexpected behavior if modified by integrations
4040
const eventDataCopy = objectAssign({}, eventData);
4141
if (properties) eventDataCopy.properties = objectAssign({}, properties);
4242
// integrationsManager does not throw errors (they are internally handled by each integration module)

src/trackers/impressionsTracker.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ export function impressionsTrackerFactory(
6060
if (impressionListener || integrationsManager) {
6161
for (let i = 0; i < impressionsToListenerCount; i++) {
6262
const impressionData: SplitIO.ImpressionData = {
63-
// copy of impression, to avoid unexpected behaviour if modified by integrations or impressionListener
63+
// copy of impression, to avoid unexpected behavior if modified by integrations or impressionListener
6464
impression: objectAssign({}, impressionsToListener[i]),
6565
attributes,
6666
ip,

src/utils/settingsValidation/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ export function settingsValidation(config: unknown, validationParams: ISettingsV
159159
if (withDefaults.mode === LOCALHOST_MODE && maybeKey === undefined) {
160160
withDefaults.core.key = 'localhost_key';
161161
} else {
162-
// Keeping same behaviour than JS SDK: if settings key or TT are invalid,
162+
// Keeping same behavior than JS SDK: if settings key or TT are invalid,
163163
// `false` value is used as bound key/TT of the default client, which leads to some issues.
164164
// @ts-ignore, @TODO handle invalid keys as a non-recoverable error?
165165
withDefaults.core.key = validateKey(log, maybeKey, LOG_PREFIX_CLIENT_INSTANTIATION);

0 commit comments

Comments
 (0)