Impression properties in consumer mode

Author: EmilianoSanchez

src/storages/utils.ts

@@ -30,6 +30,7 @@ export function impressionsToJSON(impressions: SplitIO.ImpressionDTO[], metadata
         c: impression.changeNumber,
         m: impression.time,
         pt: impression.pt,
+        properties: impression.properties
       }
     };
 

src/sync/submitters/impressionsSubmitter.ts

@@ -27,7 +27,7 @@ export function fromImpressionsCollector(sendLabels: boolean, data: SplitIO.Impr
           r: sendLabels ? entry.label : undefined, // Rule
           b: entry.bucketingKey, // Bucketing Key
           pt: entry.pt, // Previous time
-          properties: entry.properties && JSON.stringify(entry.properties) // Properties
+          properties: entry.properties // Properties
         };
 
         return keyImpression;

src/sync/submitters/types.ts

@@ -3,28 +3,30 @@ import { IMetadata } from '../../dtos/types';
 import SplitIO from '../../../types/splitio';
 import { ISyncTask } from '../types';
 
+type ImpressionPayload = {
+  /** Matching Key */
+  k: string;
+  /** Bucketing Key */
+  b?: string;
+  /** Treatment */
+  t: string;
+  /** Timestamp */
+  m: number;
+  /** Change number */
+  c: number;
+  /** Rule label */
+  r?: string;
+  /** Previous time */
+  pt?: number;
+  /** Stringified JSON object with properties */
+  properties?: string;
+};
+
 export type ImpressionsPayload = {
   /** Split name */
   f: string,
   /** Key Impressions */
-  i: {
-    /** User Key */
-    k: string;
-    /** Treatment */
-    t: string;
-    /** Timestamp */
-    m: number;
-    /** ChangeNumber */
-    c: number;
-    /** Rule label */
-    r?: string;
-    /** Bucketing Key */
-    b?: string;
-    /** Previous time */
-    pt?: number;
-    /** Stringified JSON object with properties */
-    properties?: string;
-  }[]
+  i: ImpressionPayload[]
 }[]
 
 export type ImpressionCountsPayload = {
@@ -62,23 +64,9 @@ export type StoredImpressionWithMetadata = {
   /** Metadata */
   m: IMetadata,
   /** Stored impression */
-  i: {
-    /** keyName */
-    k: string,
-    /** bucketingKey */
-    b?: string,
-    /** Split name */
-    f: string,
-    /** treatment */
-    t: string,
-    /** label */
-    r: string,
-    /** changeNumber */
-    c: number,
-    /** time */
-    m: number
-    /** previous time */
-    pt?: number
+  i: ImpressionPayload & {
+    /** Feature flag name */
+    f: string
   }
 }