Updated test cases

Author: nmayorsplit

storage/redis/rulebasedsegments.go

@@ -16,6 +16,8 @@ import (
 	"github.com/splitio/go-toolkit/v5/redis"
 )
 
+const rbsKey = "{rbsegment}"
+
 // RuleBasedSegmentStorage is a redis-based implementation of rule-based segment storage
 type RuleBasedSegmentStorage struct {
 	client *redis.PrefixedRedisClient
@@ -52,7 +54,7 @@ func (r *RuleBasedSegmentStorage) SetChangeNumber(till int64) error {
 }
 
 func (r *RuleBasedSegmentStorage) ruleBasedSegment(ruleBased string) (*dtos.RuleBasedSegmentDTO, error) {
-	keyToFetch := strings.Replace(KeyRuleBasedSegment, "{rbsegment}", ruleBased, 1)
+	keyToFetch := strings.Replace(KeyRuleBasedSegment, rbsKey, ruleBased, 1)
 	val, err := r.client.Get(keyToFetch)
 
 	if err != nil {
@@ -113,14 +115,14 @@ func (r *RuleBasedSegmentStorage) RuleBasedSegmentNames() ([]string, error) {
 	if err != nil {
 		return nil, err
 	}
-	return cleanPrefixedKeys(keys, strings.Replace(KeyRuleBasedSegment, "{rbsegment}", "", 1)), nil
+	return cleanPrefixedKeys(keys, strings.Replace(KeyRuleBasedSegment, rbsKey, "", 1)), nil
 }
 
 func (r *RuleBasedSegmentStorage) ruleBasedSegmentKeys() ([]string, error) {
 	if !r.client.ClusterMode() {
 		var cursor uint64
 		ruleBasedSegmentKeys := make([]string, 0)
-		scanKey := strings.Replace(KeyRuleBasedSegment, "{rbsegment}", "*", 1)
+		scanKey := strings.Replace(KeyRuleBasedSegment, rbsKey, "*", 1)
 		for {
 			keys, rCursor, err := r.client.Scan(cursor, scanKey, DefaultScanCount)
 			if err != nil {
@@ -287,7 +289,7 @@ func (r *RuleBasedSegmentStorage) fetchCurrentRuleBasedSegments(toAdd []dtos.Rul
 	keys := make([]string, 0, len(toAdd)+len(toRemove))
 	for _, source := range [][]dtos.RuleBasedSegmentDTO{toAdd, toRemove} {
 		for idx := range source {
-			keys = append(keys, strings.Replace(KeyRuleBasedSegment, "{rbsegment}", source[idx].Name, 1))
+			keys = append(keys, strings.Replace(KeyRuleBasedSegment, rbsKey, source[idx].Name, 1))
 		}
 	}
 

storage/redis/splits_test.go

@@ -18,6 +18,7 @@ import (
 	"github.com/splitio/go-toolkit/v5/logging"
 	"github.com/splitio/go-toolkit/v5/redis"
 	"github.com/splitio/go-toolkit/v5/redis/mocks"
+	"github.com/stretchr/testify/assert"
 )
 
 func createSampleSplit(name string, sets []string) dtos.SplitDTO {
@@ -1372,3 +1373,49 @@ func TestLargeSegmentNames(t *testing.T) {
 		t.Error(segments)
 	}
 }
+
+func TestReplaceAll(t *testing.T) {
+	logger := logging.NewLogger(nil)
+	prefix := "commons_update_prefix"
+
+	redisClient, err := NewRedisClient(&conf.RedisConfig{
+		Host:     "localhost",
+		Port:     6379,
+		Prefix:   prefix,
+		Database: 1,
+	}, logger)
+	if err != nil {
+		t.Error("It should be nil")
+	}
+	toAdd := []dtos.SplitDTO{createSampleSplit("split1", []string{}), createSampleSplit("split2", []string{}), createSampleSplit("split3", []string{})}
+
+	splitStorage := NewSplitStorage(redisClient, logging.NewLogger(&logging.LoggerOptions{}), flagsets.NewFlagSetFilter(nil))
+	splitStorage.Update(toAdd, []dtos.SplitDTO{}, 1)
+
+	splits := splitStorage.All()
+	assert.Equal(t, 3, len(splits), "Unexpected amount of split")
+	till, _ := redisClient.Get("SPLITIO.splits.till")
+	tillInt, _ := strconv.ParseInt(till, 0, 64)
+	assert.Equal(t, int64(1), tillInt, "ChangeNumber should be 1")
+
+	toReplace := []dtos.SplitDTO{createSampleSplit("split4", []string{}), createSampleSplit("split5", []string{})}
+
+	splitStorage.ReplaceAll(toReplace, 1)
+
+	splits = splitStorage.All()
+	assert.Equal(t, 2, len(splits), "Unexpected size")
+
+	till, _ = redisClient.Get("SPLITIO.splits.till")
+	tillInt, _ = strconv.ParseInt(till, 0, 64)
+	assert.Equal(t, int64(1), tillInt, "ChangeNumber should be 1")
+
+	keys := []string{
+		"SPLITIO.split.split1",
+		"SPLITIO.split.split2",
+		"SPLITIO.split.split3",
+		"SPLITIO.split.split4",
+		"SPLITIO.split.split5",
+		"SPLITIO.splits.till",
+	}
+	redisClient.Del(keys...)
+}